bug#62577: closed ([PATCH] refresh: Support select packages SUBSET by module name.)

[GNU bug Tracking System]

Your message dated Sun, 23 Apr 2023 15:36:02 +0800
with message-id <87v8hn6of1.fsf_-_@envs.net>
and subject line Re: bug#62577: [PATCH] refresh: Support select packages SUBSET 
by module name.
has caused the debbugs.gnu.org bug report #62577,
regarding [PATCH] refresh: Support select packages SUBSET by module name.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
62577: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62577
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] refresh: Support select packages SUBSET by module name.
>
>
>
>
> Date: 
>
> Sat,  1 Apr 2023 11:59:30 +0800
>
>
>
>
> From: 宋文武 <iyzsong@member.fsf.org>
>
> * guix/scripts/refresh.scm (%options): Support '--select module:NAME'.
> (show-help): Adjust accordingly.
> (options->update-specs): Honor the module passed by '--select'.
> ---
>  guix/scripts/refresh.scm | 25 ++++++++++++++++++++-----
>  1 file changed, 20 insertions(+), 5 deletions(-)
>
> diff --git a/guix/scripts/refresh.scm b/guix/scripts/refresh.scm
> index bc6c24967a..d6ac574b1f 100644
> --- a/guix/scripts/refresh.scm
> +++ b/guix/scripts/refresh.scm
> @@ -32,6 +32,7 @@ (define-module (guix scripts refresh)
>    #:use-module ((guix scripts build) #:select (%standard-build-options))
>    #:use-module (guix store)
>    #:use-module (guix utils)
> +  #:use-module (guix discovery)
>    #:use-module (guix packages)
>    #:use-module (guix profiles)
>    #:use-module (guix upstream)
> @@ -71,8 +72,15 @@ (define %options
>                      ((or "core" "non-core")
>                       (alist-cons 'select (string->symbol arg)
>                                   result))
> +                    ((? (cut string-prefix? "module:" <>))
> +                     (alist-cons 'select
> +                                 (cons 'module
> +                                       (string->symbol
> +                                        (string-drop
> +                                         arg (string-length "module:"))))
> +                                 result))
>                      (x
> -                     (leave (G_ "~a: invalid selection; expected `core' or 
> `non-core'~%")
> +                     (leave (G_ "~a: invalid selection; expected `core', 
> `non-core' or `module:NAME'~%")
>                              arg)))))
>          (option '(#\t "type") #t #f
>                  (lambda (opt name arg result)
> @@ -141,8 +149,8 @@ (define (show-help)
>    (display (G_ "
>    -u, --update           update source files in place"))
>    (display (G_ "
> -  -s, --select=SUBSET    select all the packages in SUBSET, one of
> -                         `core' or `non-core'"))
> +  -s, --select=SUBSET    select all the packages in SUBSET, one of `core`,
> +                         `non-core' or `module:NAME' (eg: module:guile)"))
>    (display (G_ "
>    -m, --manifest=FILE    select all the packages from the manifest in FILE"))
>    (display (G_ "
> @@ -257,13 +265,20 @@ (define update-specs
>         (let ((select? (match (assoc-ref opts 'select)
>                          ('core core-package?)
>                          ('non-core (negate core-package?))
> -                        (_ (const #t)))))
> +                        (_ (const #t))))
> +             (modules (match (assoc-ref opts 'select)
> +                         (('module . mod)
> +                          (list (resolve-interface `(gnu packages ,mod))))
> +                         (_ (all-modules (%package-module-path)
> +                                         #:warn
> +                                         warn-about-load-error)))))
>           (map update-spec
>                (fold-packages (lambda (package result)
>                                 (if (select? package)
>                                     (keep-newest package result)
>                                     result))
> -                             '()))))
> +                             '()
> +                             modules))))
>        (some                                       ;user-specified packages
>         some)))
>  
>
> base-commit: 1c6238794b0058003fa6c827ca0d039764ebe699
> -- 
> 2.39.2
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#62577: [PATCH] refresh: Support select packages SUBSET by module name.
>
>
>
>
> Date: 
>
> Sun, 23 Apr 2023 15:36:02 +0800
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
>
>
>
>
> Ludovic Courtès <ludo@gnu.org> writes:
>
> >> +The @code{module:NAME} subset refers to all the packages in a specified
> >
> > s/@code{module:NAME}/@code{module:@var{name}}/
> >
> > Otherwise LGTM, thanks!
>
> Pushed, thank you for review!
>
>
> --- End Message ---