bug#62292: closed ([PATCH] gnu: Add kitsas)

[GNU bug Tracking System]

Your message dated Mon, 17 Apr 2023 23:29:05 +0200
with message-id <87wn2ab3ku.fsf_-_@gnu.org>
and subject line Re: bug#62292: [PATCH] gnu: Add kitsas
has caused the debbugs.gnu.org bug report #62292,
regarding [PATCH] gnu: Add kitsas
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
62292: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62292
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: Add kitsas
>
>
>
>
> Date: 
>
> Mon, 20 Mar 2023 12:56:02 +0200
>
>
>
>
>     * gnu/packages/finance.scm (kitsas): New variable.
> ---
>  gnu/packages/finance.scm | 57 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 57 insertions(+)
>
> diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
> index 3f3fc078f0..9c27df04ad 100644
> --- a/gnu/packages/finance.scm
> +++ b/gnu/packages/finance.scm
> @@ -109,6 +109,7 @@ (define-module (gnu packages finance)
>    #:use-module (gnu packages multiprecision)
>    #:use-module (gnu packages ncurses)
>    #:use-module (gnu packages networking)
> +  #:use-module (gnu packages pdf)
>    #:use-module (gnu packages pkg-config)
>    #:use-module (gnu packages popt)
>    #:use-module (gnu packages protobuf)
> @@ -1290,6 +1291,62 @@ (define-public keepkey-agent
>  agent.")
>      (license license:lgpl3)))
>  
> +(define-public kitsas
> +  (package
> +    (name "kitsas")
> +    (version "4.0.3")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/artoh/kitupiikki/archive/refs/tags/v";
> +                    version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "1a15axggskrvjb3r3yyr3kdxyzcygxjj756b6dzpwlca5g1l7x5w"))))
> +    (build-system qt-build-system)
> +    (inputs (list qtbase-5 libzip poppler-qt5 qtsvg-5))
> +    (arguments
> +     '(#:test-target "check"
> +       #:tests? #f
> +       #:phases (modify-phases %standard-phases
> +                  (replace 'configure
> +                    (lambda* _
> +                      (invoke "qmake" "kitsasproject.pro" "CONFIG+=release")))
> +                  (replace 'install
> +                    (lambda* (#:key outputs #:allow-other-keys)
> +                      (let ((out (assoc-ref outputs "out")))
> +                        (install-file "kitsas/kitsas"
> +                                      (string-append out "/bin/"))
> +                        (install-file "kitsas.png"
> +                                      (string-append out "/share/icons/"))
> +                        (install-file "kitsas.desktop"
> +                                      (string-append out
> +                                                     
> "/share/applications/"))))))))
> +    (home-page "https://kitsas.fi";)
> +    (synopsis "Finnish bookkeeping software for small organisations")
> +    (description
> +     "The software is in Finnish only.
> +
> +      Finnish free software accounting program with the following goals and 
> features:
> +
> +      @itemize @bullet
> +      @item
> +      Ease of use
> +      @item
> +      Digital management of documents
> +      @item
> +      Creating a digital archive
> +      @item
> +      Built-in invoicing
> +      @item
> +      Creating reports
> +      @end itemize")
> +    (license license:gpl3)))
> +    ; GPL3 with additional terms:
> +    ; - Modified versions of this software should be clearly mentioned as 
> modified
> +    ; - Kitsas Oy will not support any modified version of this software
> +    ; - The name Kitsas Oy should not be used in any modified version
> +
>  (define-public python-stdnum
>    (package
>      (name "python-stdnum")
>
> base-commit: 3a2200e1ad2049ad7e25295e6b4e013f74dd84e2
> -- 
> 2.39.2
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#62292: [PATCH] gnu: Add kitsas
>
>
>
>
> Date: 
>
> Mon, 17 Apr 2023 23:29:05 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
>
>
>
>
> Hi Saku,
>
> Saku Laesvuori <saku@laesvuori.fi> skribis:
>
> >     * gnu/packages/finance.scm (kitsas): New variable.
>
> Thanks for the updated patch.  I went ahead and applied it with the
> changes below (the license is ‘gpl3+’ because the ‘LICENSE’ file
> explicitly says “version 3 or any later version”).
>
> The test failures are worrisome though.  Could you investigate why those
> tests are failing or crashing?
>
> Those failures may indicate real issues.  Or it could be that they
> require a running X server (other packages usually solve that by
> spawning ‘Xvfb’ right before the ‘check’ phase).
>
> Thank you, and thanks Bruno for reviewing.
>
> Ludo’.
>
>
> --- End Message ---