bug#62867: closed (segfault in describe_vector)

[GNU bug Tracking System]

Your message dated Sun, 16 Apr 2023 08:53:05 +0300
with message-id <83ttxgbcfy.fsf@gnu.org>
and subject line Re: bug#62867: segfault in describe_vector
has caused the debbugs.gnu.org bug report #62867,
regarding segfault in describe_vector
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
62867: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62867
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: segfault in describe_vector Date: Sat, 15 Apr 2023 08:07:07 -0400

to reproduce:

(package-initialize)
(require 'evil)
(setq testmap (make-sparse-keymap))
(define-key testmap (kbd "SPC") #'test)
(evil-define-key 'motion global-map (kbd "SPC") testmap)
(evil-mode)
(describe-keymap global-map)

This appears to be caused by keymap.c line 3313

SYMBOL_NAME (shadowed_by)

where shadowed_by don't have to be a symbol (In this case its a keymap)

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#62867: segfault in describe_vector
>
>
>
>
> Date: 
>
> Sun, 16 Apr 2023 08:53:05 +0300
>
>
>
>
> > From: Stefan Monnier <monnier@iro.umontreal.ca>
> > Cc: Xinyang Chen <chenxy@mit.edu>,  62867@debbugs.gnu.org
> > Date: Sat, 15 Apr 2023 18:16:32 -0400
> > 
> > > Stefan, can we do better than the below?
> > 
> > The patch looks about right to me.
> > 
> > Only detail is that `shadowed_by` contains a binding, so it can be
> > a keymap, but it can also be a lambda expression, or a keyboard macro,
> > so we shouldn't say "shadowed by a keymap" but just "shadowed" (unless
> > we go through the extra trouble of checking if it's a keymap, or if it's
> > a ...).
>
> Thanks, installed on the emacs-29 branch with that change, and closing
> the bug.
>
>
> --- End Message ---