--- Begin Message ---
|
Subject: |
[PATCH 0/8] Extensible define-configuration & mpd/mympd service fixes |
|
Date: |
Mon, 20 Mar 2023 16:45:47 +0000 |
Highlights:
* Make define-configuration extensible.
define-configuration can now have extra fields where custom-serializer
was located.
* New literals: sanitizer, serializer.
Support user-specified sanitizers.
* Fixes <https://issues.guix.gnu.org/61570>.
* Switch to user-account/group for mympd-service-type as well.
* Make mpd-service-type with pulseaudio usable out-of-the-box.
* Fix a mympd-service-type when logging with syslog.
Bruno Victal (8):
services: configuration: Add user-defined sanitizer support.
services: replace bare serializers with (serializer ...)
services: audio: remove redundant list-of-string? predicate.
services: mympd: Require 'syslog service when configured to log to
syslog.
services: mpd: Fix unintentional API breakage for mixer-type field.
services: mpd: Set PulseAudio related variables as default value for
environment-variables field.
services: mpd: Use user-account (resp. user-group) for user (resp.
group) fields.
services: mympd: Use user-account (resp. user-group) for user (resp.
group) fields.
doc/guix.texi | 46 +++++--
gnu/home/services/shells.scm | 12 +-
gnu/services/audio.scm | 224 ++++++++++++++++++++++---------
gnu/services/configuration.scm | 97 ++++++++++---
gnu/services/security.scm | 6 +-
tests/services/configuration.scm | 156 ++++++++++++++++++++-
6 files changed, 431 insertions(+), 110 deletions(-)
--
2.39.1
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: [PATCH v2 6/8] services: mpd: Set PulseAudio related variables as default value for environment-variables field. |
|
Date: |
Fri, 24 Mar 2023 14:10:46 -0400 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hi,
Bruno Victal <mirai@makinata.eu> writes:
> These variables are necessary for PulseAudio to work properly out-of-the-box
> for 'non-interactive' users.
> * doc/guix.texi (Audio Services): Update environment-variables field
> description for
> mpd-configuration data type.
> * gnu/services/audio.scm (mpd-configuration)[environment-variables]: Set
> PULSE_CLIENTCONFIG and PULSE_CONFIG environment variables to the system-wide
> PulseAudio configuration.
> ---
> doc/guix.texi | 2 +-
> gnu/services/audio.scm | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guix.texi b/doc/guix.texi
> index 2b62605b51..af9f7d78c0 100644
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -33501,7 +33501,7 @@ Audio Services
> This is a list of symbols naming Shepherd services that this service
> will depend on.
>
> -@item @code{environment-variables} (default: @code{()}) (type:
> list-of-strings)
> +@item @code{environment-variables} (default:
> @code{("PULSE_CLIENTCONFIG=/etc/pulse/client.conf"
> "PULSE_CONFIG=/etc/pulse/daemon.conf")}) (type: list-of-strings)
> A list of strings specifying environment variables.
>
> @item @code{log-file} (default: @code{"/var/log/mpd/log"}) (type:
> maybe-string)
> diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm
> index 56ea2f8638..198157a83b 100644
> --- a/gnu/services/audio.scm
> +++ b/gnu/services/audio.scm
> @@ -361,7 +361,8 @@ (define-configuration mpd-configuration
> empty-serializer)
>
> (environment-variables
> - (list-of-strings '())
> + (list-of-strings '("PULSE_CLIENTCONFIG=/etc/pulse/client.conf"
> + "PULSE_CONFIG=/etc/pulse/daemon.conf"))
> "A list of strings specifying environment variables."
> empty-serializer)
Installed, thank you!
--
Thanks,
Maxim
--- End Message ---