bug#62314: closed ([PATCH] gnu: emacs-buttercup: Fix build with native compilation.)

[GNU bug Tracking System]

Your message dated Fri, 24 Mar 2023 10:17:26 +0100
with message-id <878rfmzexl.fsf@nicolasgoaziou.fr>
and subject line Re: [bug#62314] [PATCH] gnu: emacs-buttercup: Fix build with 
native compilation.
has caused the debbugs.gnu.org bug report #62314,
regarding [PATCH] gnu: emacs-buttercup: Fix build with native compilation.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
62314: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62314
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] gnu: emacs-buttercup: Fix build with native compilation. Date: Tue, 21 Mar 2023 02:26:44 +0000

Hi Guix,

Here's a patch to fix emacs-buttercup failing with native-comp, i.e. guix build 
emacs-buttercup --with-input=emacs-minimal=emacs.

Here is the link to the upstream issue: 
<https://github.com/jorgenschaefer/emacs-buttercup/issues/236>

In short, it should be fixed but the fix used a variable name in current git 
Emacs which is different in the current release. So this patch adds the older 
variable name with the same fix.

I checked that it lints and native-comp and regular both build. I'll wait for 
QA to check for any other breakages. And I welcome any input on the commit 
message/code comment here.

Thanks!
John

0001-gnu-emacs-buttercup-Fix-build-with-native-compilatio.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#62314] [PATCH] gnu: emacs-buttercup: Fix build with native compilation.
>
>
>
>
> Date: 
>
> Fri, 24 Mar 2023 10:17:26 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
>
>
>
>
> Hello,
>
> John Kehayias via Guix-patches via <guix-patches@gnu.org> writes:
>
> > Here's a patch to fix emacs-buttercup failing with native-comp, i.e. guix 
> > build emacs-buttercup --with-input=emacs-minimal=emacs.
>
> Applied, with my suggested change. Thanks.
>
> Regards,
> -- 
> Nicolas Goaziou
>
>
> --- End Message ---