bug#62222: closed ([PATCH] ui: format 'display-hint' output when no arguments are passed.)

[GNU bug Tracking System]

Your message dated Fri, 17 Mar 2023 22:08:11 +0100
with message-id <87y1nvw0g4.fsf@gnu.org>
and subject line Re: [bug#62222] [PATCH] ui: format 'display-hint' output when 
no arguments are passed.
has caused the debbugs.gnu.org bug report #62222,
regarding [PATCH] ui: format 'display-hint' output when no arguments are passed.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
62222: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62222
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] ui: format 'display-hint' output when no arguments are passed.
>
>
>
>
> Date: 
>
> Thu, 16 Mar 2023 16:11:20 +0000
>
>
>
>
> When display-hint is given format specifiers such as "~%" but no arguments,
> it does not format the output, causing the specifiers to be visible in the
> displayed text.
>
> * guix/ui.scm (display-hint): Format output when no arguments are passed.
> ---
> Steps to reproduce the issue this fixes:
> $ guix build -s whatever hello
>
> guix build: error: 'whatever' is not a supported system
> hint: Try `--list-systems' to view available system types.~%
>
>  guix/ui.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guix/ui.scm b/guix/ui.scm
> index b6c3bd04ba..7540e2194f 100644
> --- a/guix/ui.scm
> +++ b/guix/ui.scm
> @@ -323,7 +323,7 @@ (define colorize
>     ;; XXX: We should arrange so that the initial indent is wider.
>     (parameterize ((%text-width (max 15 (- (terminal-columns) 5))))
>       (texi->plain-text (match arguments
> -                         (() message)
> +                         (() (format #f message))
>                           (_  (apply format #f message
>                                      (map (match-lambda
>                                             ((? string? str)
> -- 
> 2.38.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#62222] [PATCH] ui: format 'display-hint' output when no arguments are passed.
>
>
>
>
> Date: 
>
> Fri, 17 Mar 2023 22:08:11 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
>
>
>
>
> Hi,
>
> Antero Mejr <antero@mailbox.org> skribis:
>
> > When display-hint is given format specifiers such as "~%" but no arguments,
> > it does not format the output, causing the specifiers to be visible in the
> > displayed text.
> >
> > * guix/ui.scm (display-hint): Format output when no arguments are passed.
>
> Oops, good catch!  Applied, thanks.
>
> Ludo’.
>
>
> --- End Message ---