--- Begin Message ---
|
Subject: |
30.0.50; Submitting elixir-ts-mode and heex-ts-mode |
|
Date: |
Mon, 06 Mar 2023 09:04:13 +0200 |
|
User-agent: |
mu4e 1.9.3; emacs 30.0.50 |
I would like to submit elixir-ts-mode and heex-ts-mode to emacs
master.
The package elixir-ts-mode and its dependency heex-ts-mode is
currently a melpa package: https://melpa.org/#/elixir-ts-mode.
This is a
slightly simplified version, also authored by me.
There is one change not authored by me:
https://github.com/wkirschbaum/elixir-ts-mode/commit/21ad74877ebb55f4bf0b31c2f463bbfda72590ef
which is a duplication removal.
I completed the assignment process in Jan.
0001-Add-heex-ts-mode.patch
Description: Add heex-ts-mode
0002-Add-elixir-ts-mode.patch
Description: Add elixir-ts-mode
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#61996: 30.0.50; Submitting elixir-ts-mode and heex-ts-mode |
|
Date: |
Sun, 12 Mar 2023 17:46:41 +0200 |
> From: Wilhelm Kirschbaum <wkirschbaum@gmail.com>
> Cc: 61996@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no
> Date: Sun, 12 Mar 2023 17:14:03 +0200
>
> Attached are the updated patches with added test cases and
> indentation rule enhancements.
Thanks, installed on master.
> I still see this warning on a non-treesitter build:
>
> In elixir-ts--forward-sexp:
> elixir-ts-mode.el:490:8: Warning: reference to free variable
> ‘heex-ts--sexp-regexp’
Doesn't happen here, so I think we are good.
> Random concern: how will backwards compatibility work when the
> grammars get updated?
Let's discuss this when such problems actually happen. The answer
depends on what kind of incompatibilities are introduced by changes in
the grammars.
> It might just be better to add both modes in one patch if more
> changes are required perhaps?
I'm not sure I understand the question.
In general, we like each commit to be as self-contained and
independent of the others as possible. Not sure if this answers your
question.
Thanks, I'm closing this bug.
--- End Message ---