bug#61842: closed ([PATCH] file-systems: Remove deprecated 'title' field helper procedures.)

[GNU bug Tracking System]

Your message dated Sun, 05 Mar 2023 23:05:43 +0100
with message-id <87jzzuonuw.fsf@gnu.org>
and subject line Re: bug#61842: [PATCH] file-systems: Remove deprecated 'title' 
field helper procedures.
has caused the debbugs.gnu.org bug report #61842,
regarding [PATCH] file-systems: Remove deprecated 'title' field helper 
procedures.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
61842: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61842
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] file-systems: Remove deprecated 'title' field helper procedures.
>
>
>
>
> Date: 
>
> Mon, 27 Feb 2023 14:59:39 +0000
>
>
>
>
> * gnu/system/file-systems.scm (<file-system>): Change constructor name to 
> 'file-system'.
> (report-deprecation, device-expression, process-file-system-declaration, 
> file-system): Remove macros.
> (file-system-title): Remove procedure.
> ---
>  gnu/system/file-systems.scm | 69 +------------------------------------
>  1 file changed, 1 insertion(+), 68 deletions(-)
>
> diff --git a/gnu/system/file-systems.scm b/gnu/system/file-systems.scm
> index f2eb2e0837..b236011100 100644
> --- a/gnu/system/file-systems.scm
> +++ b/gnu/system/file-systems.scm
> @@ -42,7 +42,6 @@ (define-module (gnu system file-systems)
>              file-system?
>              file-system-device
>              file-system-device->string
> -            file-system-title                     ;deprecated
>              file-system-mount-point
>              file-system-type
>              file-system-needed-for-boot?
> @@ -158,7 +157,7 @@ (define-syntax validate-file-system-flags
>         #'%validate-file-system-flags))))
>  
>  ;; File system declaration.
> -(define-record-type* <file-system> %file-system
> +(define-record-type* <file-system> file-system
>    make-file-system
>    file-system?
>    (device           file-system-device) ; string | <uuid> | <file-system-label>
> @@ -200,72 +199,6 @@ (define-record-type <file-system-label>
>                              (format port "#<file-system-label ~s>"
>                                      (file-system-label->string obj))))
>  
> -(define-syntax report-deprecation
> -  (lambda (s)
> -    "Report the use of the now-deprecated 'title' field."
> -    (syntax-case s ()
> -      ((_ field)
> -       (let* ((source (syntax-source #'field))
> -              (file   (and source (assq-ref source 'filename)))
> -              (line   (and source
> -                           (and=> (assq-ref source 'line) 1+)))
> -              (column (and source (assq-ref source 'column))))
> -         (format (current-error-port)
> -                 "~a:~a:~a: warning: 'title' field is deprecated~%"
> -                 file line column)
> -         #t)))))
> -
> -;; Helper for 'process-file-system-declaration'.
> -(define-syntax device-expression
> -  (syntax-rules (quote label uuid device)
> -    ((_ (quote label) dev)
> -     (file-system-label dev))
> -    ((_ (quote uuid) dev)
> -     (if (uuid? dev) dev (uuid dev)))
> -    ((_ (quote device) dev)
> -     dev)
> -    ((_ title dev)
> -     (case title
> -       ((label) (file-system-label dev))
> -       ((uuid)  (uuid dev))
> -       (else    dev)))))
> -
> -;; Helper to interpret the now-deprecated 'title' field.  Detect forms like
> -;; (title 'label), remove them, and adjust the 'device' field accordingly.
> -;; TODO: Remove this once 'title' has been deprecated long enough.
> -(define-syntax process-file-system-declaration
> -  (syntax-rules (device title)
> -    ((_ () (rest ...) #f #f)                 ;no 'title' and no 'device' field
> -     (%file-system rest ...))
> -    ((_ () (rest ...) dev #f)                     ;no 'title' field
> -     (%file-system rest ... (device dev)))
> -    ((_ () (rest ...) dev titl)                   ;got a 'title' field
> -     (%file-system rest ...
> -                   (device (device-expression titl dev))))
> -    ((_ ((title titl) rest ...) (previous ...) dev _)
> -     (begin
> -       (report-deprecation (title titl))
> -       (process-file-system-declaration (rest ...)
> -                                        (previous ...)
> -                                        dev titl)))
> -    ((_ ((device dev) rest ...) (previous ...) _ titl)
> -     (process-file-system-declaration (rest ...)
> -                                      (previous ...)
> -                                      dev titl))
> -    ((_ (field rest ...) (previous ...) dev titl)
> -     (process-file-system-declaration (rest ...)
> -                                      (previous ... field)
> -                                      dev titl))))
> -
> -(define-syntax-rule (file-system fields ...)
> -  (process-file-system-declaration (fields ...) () #f #f))
> -
> -(define (file-system-title fs)                    ;deprecated
> -  (match (file-system-device fs)
> -    ((? file-system-label?) 'label)
> -    ((? uuid?)              'uuid)
> -    ((? string?)            'device)))
> -
>  ;; Note: This module is used both on the build side and on the host side.
>  ;; Arrange not to pull (guix store) and (guix config) because the latter
>  ;; differs from user to user.
> -- 
> 2.39.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#61842: [PATCH] file-systems: Remove deprecated 'title' field helper procedures.
>
>
>
>
> Date: 
>
> Sun, 05 Mar 2023 23:05:43 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
>
>
>
>
> Hi,
>
> Bruno Victal <mirai@makinata.eu> skribis:
>
> > * gnu/system/file-systems.scm (<file-system>): Change constructor name to 
> > 'file-system'.
> > (report-deprecation, device-expression, process-file-system-declaration, 
> > file-system): Remove macros.
> > (file-system-title): Remove procedure.
>
> Good riddance.  :-)  Applied, thanks!
>
> Ludo’.
>
>
> --- End Message ---