bug#61186: closed (build failure when building from git source in a subdirectory)

[GNU bug Tracking System]

Your message dated Mon, 30 Jan 2023 14:57:24 -0800
with message-id <3cd6170f-3f39-bf22-106e-9f778e3686b0@cs.ucla.edu>
and subject line Re: bug#61186: build failure when building from git source in 
a subdirectory
has caused the debbugs.gnu.org bug report #61186,
regarding build failure when building from git source in a subdirectory
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
61186: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61186
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: build failure when building from git source in a subdirectory Date: Mon, 30 Jan 2023 22:28:57 +0100

Hi,

When building gzip from the git repository in a subdirectory (VPATH build),
I get a build failure.

How to reproduce:

$ unset GNULIB_SRCDIR
$ git clone https://git.savannah.gnu.org/git/gzip.git
$ cd gzip
$ ./bootstrap
$ mkdir vpath
$ cd vpath
$ ../configure
$ make
$ make check
...
make[3]: Entering directory '/tmp/gzip/vpath'
  GEN      gzip.doc
  GEN      gzip.doc.gz
/bin/bash: line 1: ../gzip.doc: No such file or directory
make[3]: *** [Makefile:2435: gzip.doc.gz] Error 1
make[3]: Leaving directory '/tmp/gzip/vpath'

The problem is that while gzip.doc is expected to be in the source
directory (1. because it's in EXTRA_DIST, 2. see the check-local rule),
it's being generated in the build directory. The GNU Coding Standards
<https://www.gnu.org/prep/standards/html_node/Makefile-Basics.html>
make it clear that the file should be generated in the source directory.

The attached patch fixes it. I verified that "make distcheck" passes.

0001-Fix-make-check-in-a-subdirectory-VPATH-build.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#61186: build failure when building from git source in a subdirectory
>
>
>
>
> Date: 
>
> Mon, 30 Jan 2023 14:57:24 -0800
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0
>
>
>
>
> Thanks, I installed that.
>
>
> --- End Message ---