bug#58955: closed ([PATCH] gnu: pd: Update to 0.53-0, unbundle oss and portaudio)

[GNU bug Tracking System]

Your message dated Sun, 29 Jan 2023 14:56:57 +0800
with message-id <878rhlj0au.fsf_-_@envs.net>
and subject line Re: bug#58955: [PATCH] gnu: pd: Update to 0.53-0, unbundle oss 
and portaudio
has caused the debbugs.gnu.org bug report #58955,
regarding [PATCH] gnu: pd: Update to 0.53-0, unbundle oss and portaudio
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
58955: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58955
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: pd: Update to 0.53-0, unbundle oss and portaudio
>
>
>
>
> Date: 
>
> Wed, 02 Nov 2022 01:28:21 +0000
>
>
>
>
> * gnu/packages/music.scm (pd): Update to 0.53-0.
> [arguments]: Unbundle oss and portaudio.
> [inputs]: Add portaudio.
> ---
>  gnu/packages/music.scm | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index ca400e8..b018c8e 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -2693,24 +2693,26 @@ export.")
>  (define-public pd
>    (package
>      (name "pd")
> -    (version "0.52-2")
> +    (version "0.53-0")
>      (source (origin
>                (method url-fetch)
>                (uri
>                 (string-append "http://msp.ucsd.edu/Software/pd-";
>                                version ".src.tar.gz"))
>                (sha256
>                 (base32
> -                "04fcsfgnv2r7g7p8vk9s9n3wba1bx4xgqw5mhwv09xbw9s3gapg9"))))
> +                "01zcgw4bg4r422ikqa0d4s7vpgjjz76scnm4l1msnm35y7pzknns"))))
>      (build-system gnu-build-system)
>      (arguments
>       (let ((wish (string-append "wish" (version-major+minor
>                                          (package-version tk)))))
>         (list
>          #:tests? #f                     ; no "check" target
>          #:configure-flags
>          #~(list
> +           "--disable-oss"
>             "--enable-jack"
> +           "--without-local-portaudio"
>             (string-append "--with-wish="
>                            (search-input-file %build-inputs
>                                               (string-append "/bin/" #$wish))))
> @@ -2724,7 +2726,7 @@ export.")
>      (native-inputs
>       (list autoconf automake libtool gettext-minimal pkg-config))
>      (inputs
> -     (list tk alsa-lib jack-1))
> +     (list tk alsa-lib jack-1 portaudio))
>      (home-page "https://puredata.info";)
>      (synopsis "Visual programming language for artistic performances")
>      (description
> --
> libgit2 1.4.3
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#58955: [PATCH] gnu: pd: Update to 0.53-0, unbundle oss and portaudio
>
>
>
>
> Date: 
>
> Sun, 29 Jan 2023 14:56:57 +0800
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
>
>
>
>
> Sughosha <Sughosha@proton.me> writes:
>
> > Hi Christopher,
> >
> > Thanks for reviewing the patch.
> >
> >> From the diff, it looks like oss is being disabled, rather than
> >> unbundled. What's the reasoning behind disabling it?
> > OSS is not needed since it was superseded by ALSA and it does the job.
> > I disabled it because it's not at all used in Guix and also not needed
> > as we have ALSA. Sorry for not being accurate in the message.
> >> 
> >> Adding portaudio as an input seems fine I guess, but it might be good to
> >> remove the portaudio files from the source (through a snippet) if there
> >> are some there.
> > I tried it but autoconf or automake looks for it and gives error, before
> > starting building.
>
> Pushed with adjusted commit message, thank you!
>
>
> --- End Message ---