bug#59157: closed ([PATCH] snippets: yas: Add snippets for vc.el)

[GNU bug Tracking System]

Your message dated Mon, 28 Nov 2022 22:55:05 +0100
with message-id <87sfi2922u.fsf@gnu.org>
and subject line Re: bug#59157: [PATCH] snippets: yas: Add snippets for vc.el
has caused the debbugs.gnu.org bug report #59157,
regarding [PATCH] snippets: yas: Add snippets for vc.el
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
59157: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59157
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] snippets: yas: Add snippets for vc.el
>
>
>
>
> Date: 
>
> Wed,  9 Nov 2022 15:10:02 -0500
>
>
>
>
> From: Morgan Smith <Morgan.J.Smith@outlook.com>
>
> * etc/snippets/yas/log-edit-mode/guix-vc-commit-message-add-package:
> * etc/snippets/yas/log-edit-mode/guix-vc-commit-message-remove-package:
> * etc/snippets/yas/log-edit-mode/guix-vc-commit-message-rename-package:
> * etc/snippets/yas/log-edit-mode/guix-vc-commit-message-update-package:
> * etc/snippets/yas/log-edit-mode/guix-vc-commit-message-use-https-home-page:
> New file
> ---
>
> This recreates the magit snippets but with the builtin Emacs vc stuff.  It
> shouldn't conflict with the magit snippets since it will only active in
> log-edit-mode (which magit doesn't use).
>
> I didn't really test the rename snippet because testing is hard and I have no
> clue what the add-cl-package snippet does so I didn't try to recreate that one.
>
>
>  .../guix-vc-commit-message-add-package             |  9 +++++++++
>  .../guix-vc-commit-message-remove-package          |  9 +++++++++
>  .../guix-vc-commit-message-rename-package          | 14 ++++++++++++++
>  .../guix-vc-commit-message-update-package          | 12 ++++++++++++
>  .../guix-vc-commit-message-use-https-home-page     |  9 +++++++++
>  5 files changed, 53 insertions(+)
>  create mode 100644 
> etc/snippets/yas/log-edit-mode/guix-vc-commit-message-add-package
>  create mode 100644 
> etc/snippets/yas/log-edit-mode/guix-vc-commit-message-remove-package
>  create mode 100644 
> etc/snippets/yas/log-edit-mode/guix-vc-commit-message-rename-package
>  create mode 100644 
> etc/snippets/yas/log-edit-mode/guix-vc-commit-message-update-package
>  create mode 100644 
> etc/snippets/yas/log-edit-mode/guix-vc-commit-message-use-https-home-page
>
> diff --git a/etc/snippets/yas/log-edit-mode/guix-vc-commit-message-add-package 
> b/etc/snippets/yas/log-edit-mode/guix-vc-commit-message-add-package
> new file mode 100644
> index 0000000000..cc2dddb1e0
> --- /dev/null
> +++ b/etc/snippets/yas/log-edit-mode/guix-vc-commit-message-add-package
> @@ -0,0 +1,9 @@
> +# -*- mode: snippet -*-
> +# name: guix-vc-commit-message-add-package
> +# key: add
> +# --
> +gnu: Add ${1:`(when (string-match "\\+(define-public \\(\\S-+\\)" 
> vc-patch-string)
> +                (match-string-no-properties 1 vc-patch-string))`}.
> +
> +* `(car (log-edit-files))` ($1): New variable.
> +`(mapconcat (lambda (file) (concat "* " file)) (cdr (log-edit-files)) "\n")`
> diff --git 
> a/etc/snippets/yas/log-edit-mode/guix-vc-commit-message-remove-package 
> b/etc/snippets/yas/log-edit-mode/guix-vc-commit-message-remove-package
> new file mode 100644
> index 0000000000..9ab4ce6156
> --- /dev/null
> +++ b/etc/snippets/yas/log-edit-mode/guix-vc-commit-message-remove-package
> @@ -0,0 +1,9 @@
> +# -*- mode: snippet -*-
> +# name: guix-vc-commit-message-remove-package
> +# key: remove
> +# --
> +gnu: Remove ${1:`(when (string-match "\\-(define-public \\(\\S-+\\)" 
> vc-patch-string)
> +                   (match-string-no-properties 1 vc-patch-string))`}.
> +
> +* `(car (log-edit-files))` ($1): Delete variable.
> +`(mapconcat (lambda (file) (concat "* " file)) (cdr (log-edit-files)) "\n")`
> diff --git 
> a/etc/snippets/yas/log-edit-mode/guix-vc-commit-message-rename-package 
> b/etc/snippets/yas/log-edit-mode/guix-vc-commit-message-rename-package
> new file mode 100644
> index 0000000000..89c85f8016
> --- /dev/null
> +++ b/etc/snippets/yas/log-edit-mode/guix-vc-commit-message-rename-package
> @@ -0,0 +1,14 @@
> +# -*- mode: snippet -*-
> +# name: guix-vc-commit-message-rename-package
> +# key: rename
> +# --
> +gnu: ${1:`(when (string-match "\\-(define-public \\(\\S-+\\)" vc-patch-string)
> +            (match-string-no-properties 1 vc-patch-string))
> +            `}: Rename package to ${2:`
> +            (when (string-match "\\+(define-public \\(\\S-+\\)" 
> vc-patch-string)
> +            (match-string-no-properties 1 vc-patch-string))`}.
> +
> +* `(car (log-edit-files))` ($1): Define in terms of
> +'deprecated-package'.
> +($2): New variable, formerly known as "$1".
> +`(mapconcat (lambda (file) (concat "* " file)) (cdr (log-edit-files)) "\n")`
> diff --git 
> a/etc/snippets/yas/log-edit-mode/guix-vc-commit-message-update-package 
> b/etc/snippets/yas/log-edit-mode/guix-vc-commit-message-update-package
> new file mode 100644
> index 0000000000..b5e41709f5
> --- /dev/null
> +++ b/etc/snippets/yas/log-edit-mode/guix-vc-commit-message-update-package
> @@ -0,0 +1,12 @@
> +# -*- mode: snippet -*-
> +# name: guix-vc-commit-message-update-package
> +# key: update                                  
> +# --
> +
> +gnu: ${1:`(when (string-match "^[ ]*(define-public \\(\\S-+\\)" 
> vc-patch-string)
> +            (match-string-no-properties 1 vc-patch-string))`}: Update to ${2:`
> +          (when (string-match "^\\+[ ]*(version \"\\(.*\\)\"" vc-patch-string)
> +            (match-string-no-properties 1 vc-patch-string))`}.
> +
> +* `(car (log-edit-files))` ($1): Update to $2.$0
> +`(mapconcat (lambda (file) (concat "* " file)) (cdr (log-edit-files)) "\n")`
> diff --git 
> a/etc/snippets/yas/log-edit-mode/guix-vc-commit-message-use-https-home-page 
> b/etc/snippets/yas/log-edit-mode/guix-vc-commit-message-use-https-home-page
> new file mode 100644
> index 0000000000..e0f170b015
> --- /dev/null
> +++ b/etc/snippets/yas/log-edit-mode/guix-vc-commit-message-use-https-home-page
> @@ -0,0 +1,9 @@
> +# -*- mode: snippet -*-
> +# name: guix-vc-commit-message-use-https-home-page
> +# key: https
> +# --
> +gnu: ${1:`(when (string-match "^[ ]*(define-public \\(\\S-+\\)" 
> vc-patch-string)
> +            (match-string-no-properties 1 vc-patch-string))`}: Use HTTPS home 
> page URI.
> +
> +* `(car (log-edit-files))` ($1)[home-page]: Use HTTPS URI.
> +`(mapconcat (lambda (file) (concat "* " file)) (cdr (log-edit-files)) "\n")`
> -- 
> 2.38.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#59157: [PATCH] snippets: yas: Add snippets for vc.el
>
>
>
>
> Date: 
>
> Mon, 28 Nov 2022 22:55:05 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
>
>
>
>
> Hi,
>
> Morgan.J.Smith@outlook.com skribis:
>
> > From: Morgan Smith <Morgan.J.Smith@outlook.com>
> >
> > * etc/snippets/yas/log-edit-mode/guix-vc-commit-message-add-package:
> > * etc/snippets/yas/log-edit-mode/guix-vc-commit-message-remove-package:
> > * etc/snippets/yas/log-edit-mode/guix-vc-commit-message-rename-package:
> > * etc/snippets/yas/log-edit-mode/guix-vc-commit-message-update-package:
> > * etc/snippets/yas/log-edit-mode/guix-vc-commit-message-use-https-home-page:
> > New file
> > ---
> >
> > This recreates the magit snippets but with the builtin Emacs vc stuff.  It
> > shouldn't conflict with the magit snippets since it will only active in
> > log-edit-mode (which magit doesn't use).
> >
> > I didn't really test the rename snippet because testing is hard and I have no
> > clue what the add-cl-package snippet does so I didn't try to recreate that 
> > one.
>
> Alright.  I didn’t test it but it looks reasonable and safe, so I went
> ahead and applied it.
>
> Thanks!
>
> Ludo’.
>
>
> --- End Message ---