bug#59126: closed ([PATCH] gnu: go-github-com-zenhack-go-notmuch: Use UNGEXP-NATIVE with NOTMUCH-FIXTURES.)

[GNU bug Tracking System]

Your message dated Sun, 20 Nov 2022 12:09:00 +0000
with message-id <878rk5x1x5.fsf@cbaines.net>
and subject line Re: [bug#59126] [PATCH] gnu: go-github-com-zenhack-go-notmuch: 
Use UNGEXP-NATIVE with NOTMUCH-FIXTURES.
has caused the debbugs.gnu.org bug report #59126,
regarding [PATCH] gnu: go-github-com-zenhack-go-notmuch: Use UNGEXP-NATIVE with 
NOTMUCH-FIXTURES.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
59126: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59126
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: go-github-com-zenhack-go-notmuch: Use UNGEXP-NATIVE with NOTMUCH-FIXTURES.
>
>
>
>
> Date: 
>
> Tue,  8 Nov 2022 17:19:58 +0000
>
>
>
>
> * gnu/packages/golang.scm (go-github-com-zenhack-go-notmuch)
>   [arguments]<#:phases>{'unpack-test-fixtures}: Use UNGEXP-NATIVE with
>   NOTMUCH-FIXTURES.
> ---
>  gnu/packages/golang.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
> index e52161228e..26b5048ed0 100644
> --- a/gnu/packages/golang.scm
> +++ b/gnu/packages/golang.scm
> @@ -10371,7 +10371,7 @@ (define-public go-github-com-zenhack-go-notmuch
>                            (lambda* (#:key inputs import-path
>                                      #:allow-other-keys)
>                              (invoke "tar" "xf"
> -                                    #$notmuch-fixtures "-C"
> +                                    #+notmuch-fixtures "-C"
>                                      (string-append "src/" import-path
>                                                     "/fixtures")))))))
>      (inputs (list notmuch))
>
> base-commit: 96ae718c516a289124a0b91ceeef78b20d187825
> -- 
> 2.38.0
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#59126] [PATCH] gnu: go-github-com-zenhack-go-notmuch: Use UNGEXP-NATIVE with NOTMUCH-FIXTURES. Date: Sun, 20 Nov 2022 12:09:00 +0000 User-agent: mu4e 1.8.11; emacs 28.2

"(" <paren@disroot.org> writes:

> On Sun Nov 20, 2022 at 11:28 AM GMT, Christopher Baines wrote:
>> I can guess at why you might be wanting to change this, but I'm
>> interested in what your actual reasoning is (and it's good if this is in
>> the commit message to)?
>
> Well, since NOTMUCH-FIXTURES is just an origin, it won't differ on
> different systems. So, we don't need to cross-compile it, because a
> non-cross-compiled version will work just as well. But Guix has no
> way of knowing this, so if we use UNGEXP, it'll re-build the origin
> unnecessarily. If we use UNGEXP-NATIVE, it'll just use the host's
> NOTMUCH-FIXTURES.

Thanks. And yeah, given notmuch-fixtures is just an origin, maybe this
just does make sense without any extra explaination.

I've gone ahead and pushed this to master as
cfec9f055272feb6fca8c52ba92c8e7d831052ac.

Chris

signature.asc
Description: PGP signature

--- End Message ---