bug#59127: closed ([PATCH] guix-install.sh: remove unnecessary XDG_DATA_DIRS export.)

[GNU bug Tracking System]

Your message dated Mon, 14 Nov 2022 10:27:20 +0800
with message-id <877czyb793.fsf@envs.net>
and subject line Re: bug#59127: [PATCH] guix-install.sh: remove unnecessary 
XDG_DATA_DIRS export.
has caused the debbugs.gnu.org bug report #59127,
regarding [PATCH] guix-install.sh: remove unnecessary XDG_DATA_DIRS export.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
59127: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59127
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] guix-install.sh: remove unnecessary XDG_DATA_DIRS export. Date: Tue, 08 Nov 2022 09:47:57 +0000

Hello there,

Here's a small patch.

Regards.

0001-guix-install.sh-remove-unnecessary-XDG_DATA_DIRS-exp.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#59127: [PATCH] guix-install.sh: remove unnecessary XDG_DATA_DIRS export.
>
>
>
>
> Date: 
>
> Mon, 14 Nov 2022 10:27:20 +0800
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
>
>
>
>
> Prafulla Giri <prafulla.giri@protonmail.com> writes:
>
> > Hello there,
> >
> > Here's a small patch.
> >
> > Regards.
> >
> > From 22a94cf122a8f01ba8078255031cc520f4f1b70d Mon Sep 17 00:00:00 2001
> > From: Prafulla Giri <prafulla.giri@protonmail.com>
> > Date: Tue, 8 Nov 2022 13:39:21 +0545
> > Subject: [PATCH] guix-install.sh: remove unnecessary XDG_DATA_DIRS export.
> >
> > This started out as a bug-fix for a GUI login loop that was resulting from 
> > XDG_DATA_DIRS
> > not including any of the host distro's directories. The solution was to 
> > export the vari-
> > able (with fail-safe defaults) before source-ing GUIX_PROFILE/etc/profile. It 
> > turns out
> > changes have already been made to ensure that XDG_DATA_DIRS, etc. are always 
> > exported
> > before anything guix-specific. So, this export is no longer necessary.
> >
> > For reference, the aforementioned bug was found on a Debian 11 machine and 
> > it's guix.sh
> > init profile for guix version 1.2.
> > ---
> >  etc/guix-install.sh | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/etc/guix-install.sh b/etc/guix-install.sh
> > index c8ef59d4a4..21253f538b 100755
> > --- a/etc/guix-install.sh
> > +++ b/etc/guix-install.sh
> > @@ -10,6 +10,7 @@
> >  # Copyright © 2021 Jakub Kądziołka <kuba@kadziolka.net>
> >  # Copyright © 2021 Chris Marusich <cmmarusich@gmail.com>
> >  # Copyright © 2021, 2022 Maxim Cournoyer <maxim.cournoyer@gmail.com>
> > +# Copyright © 2019, 2020, 2022 Prafulla Giri <prafulla.giri@protonmail.com>
>
> I changed copyright years to only '2022'.
>
> Pushed, thank you!
>
>
> --- End Message ---