bug#59139: closed (29.0.50; batch-byte-recompile-directory doesn't recompile file as expected)

[GNU bug Tracking System]

Your message dated Sun, 13 Nov 2022 07:22:36 +0000
with message-id <87edu7wc77.fsf@posteo.net>
and subject line Re: bug#59236: 29.0.50; [PATCH] bytecomp.el: 
(byte-recompile-directory): Fix negated ignore
has caused the debbugs.gnu.org bug report #59236,
regarding 29.0.50; batch-byte-recompile-directory doesn't recompile file as 
expected
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
59236: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59236
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: 29.0.50; batch-byte-recompile-directory doesn't recompile file as expected Date: Wed, 9 Nov 2022 02:19:22 +0100 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2

Hello,

I recently observed that batch-byte-recompile-directory no more
recompile .el files newer than their .elc file.

Here is the shell command I use:

emacs -batch --no-init-file --no-site-file --eval "(setq load-path [my
load path])" -f batch-byte-recompile-directory .

After some investigation, I found that commit
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=8638aace3fbe01529f33870f469fa60bf5e43ee7
could be the culprit.

The attached patch fixed the above commit and solved the issue for me.

Thanks

In GNU Emacs 29.0.50 (build 6, x86_64-pc-linux-gnu, GTK+ Version
 3.24.34, cairo version 1.17.6) of 2022-11-07 built on kilauea
Repository revision: d04433b96215d7d3387573f19cc315de86f2341a
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12014000
System Description: Fedora Linux 36 (KDE Plasma)

Configured using:
 'configure --prefix=/home/dponce --with-x-toolkit=gtk3
 PKG_CONFIG_PATH=/usr/local/lib/pkgconfig:/usr/lib/pkgconfig'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

Important settings:
  value of $LC_TIME: fr_FR.utf8
  value of $LANG: fr_FR.UTF-8
  locale-coding-system: utf-8-unix

bytecomp.el.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#59236: 29.0.50; [PATCH] bytecomp.el: (byte-recompile-directory): Fix negated ignore
>
>
>
>
> Date: 
>
> Sun, 13 Nov 2022 07:22:36 +0000
>
>
>
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > merge 59236 59139
> > thanks
> >
> >> Date: Sun, 13 Nov 2022 04:26:45 +0000
> >> From:  lin Sun via "Bug reports for GNU Emacs,
> >>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> >> 
> >> The patch 8638aace3f try to use the variable
> >> `byte-compile-ignore-files`, but the logic is inverse for both file
> >> and directory parts;
> >> and the patch a01024c859 fix the logic for file part;
> >> this patch try to fix the logic for directory part.
> >> 
> >> Please help review and apply it. Thanks.
> >
> > This is a duplicate of bug#59139.
> >
> > Philip, can you please take care of this?
>
> I had applied the patch that was identical to the one proposed here, but
> it appears my message confirming that wasn't sent out.  I'll update both
> bug reports.
>
>
> --- End Message ---