bug#58448: closed ([PATCH] gnu: helm: fix not finding Factory Presets)

[GNU bug Tracking System]

Your message dated Sat, 29 Oct 2022 23:53:59 +0200
with message-id <87bkpupa88.fsf@nicolasgoaziou.fr>
and subject line Re: [bug#58448] [PATCH] gnu: helm: fix not finding Factory 
Presets
has caused the debbugs.gnu.org bug report #58448,
regarding [PATCH] gnu: helm: fix not finding Factory Presets
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
58448: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58448
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: helm: fix not finding Factory Presets
>
>
>
>
> Date: 
>
> Tue, 11 Oct 2022 18:34:21 +0000
>
>
>
>
> * gnu/packages/music.scm (helm): Fix not finding Factory Presets.
>   This change fixes hardcoded paths so that Factory Presets can be found.
> ---
>  gnu/packages/music.scm | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index 6b37c79389..000b372303 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -6144,6 +6144,13 @@ (define-public helm
>               (substitute* "Makefile"
>                 (("/usr") ""))
>               #t))
> +         (add-after 'unpack 'fix-hardcoded-paths
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (substitute* "src/common/load_save.cpp"
> +               (("/usr") (assoc-ref outputs "out")))
> +             (substitute* "src/editor_sections/patch_browser.cpp"
> +               (("/usr") (assoc-ref outputs "out")))
> +             #t))
>           (delete 'configure))))
>      (inputs
>       `(("alsa-lib" ,alsa-lib)
> -- 
> 2.38.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#58448] [PATCH] gnu: helm: fix not finding Factory Presets
>
>
>
>
> Date: 
>
> Sat, 29 Oct 2022 23:53:59 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
>
>
>
>
> Hello,
>
> Sughosha via Guix-patches via <guix-patches@gnu.org> writes:
>
> > * gnu/packages/music.scm (helm): Fix not finding Factory Presets.
> >   This change fixes hardcoded paths so that Factory Presets can be
> >   found.
>
> Thank you.  Applied with the following changes:
>
> > +         (add-after 'unpack 'fix-hardcoded-paths
> > +           (lambda* (#:key outputs #:allow-other-keys)
> > +             (substitute* "src/common/load_save.cpp"
> > +               (("/usr") (assoc-ref outputs "out")))
> > +             (substitute* "src/editor_sections/patch_browser.cpp"
> > +               (("/usr") (assoc-ref outputs "out")))
> > +             #t))
>
> I removed trailing #t, and merged both substitute* calls.
>
> Regards,
> -- 
> Nicolas Goaziou
>
>
> --- End Message ---