bug#58708: closed (29.0.50; [PATCH] Fix build error that gflags.will_dump_ not surround by the directives as its definition)

[GNU bug Tracking System]

Your message dated Tue, 25 Oct 2022 14:57:05 +0300
with message-id <8335bcp14e.fsf@gnu.org>
and subject line Re: 29.0.50; [PATCH] Fix build error that gflags.will_dump_ 
not surround by the directives as its definition
has caused the debbugs.gnu.org bug report #58708,
regarding 29.0.50; [PATCH] Fix build error that gflags.will_dump_ not surround 
by the directives as its definition
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
58708: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58708
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: 29.0.50; [PATCH] Fix build error that gflags.will_dump_ not surround by the directives as its definition Date: Sat, 22 Oct 2022 05:16:45 +0000

Hi,

The "gflags.will_dump_" is defined in the lisp.h and surround by these
directives,

#if defined HAVE_PDUMPER || defined HAVE_UNEXEC

  bool will_dump_ : 1;

#endif

But its references weren't surrounded with the same directives, so
emacs will fail to build without any dumper.

This patch will fix the build errors. Please review and merge this patch. Thanks

Best Regards
Lin

0001-lisp.h-suround-the-gflags.will_dump_-with-same-direc.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: 29.0.50; [PATCH] Fix build error that gflags.will_dump_ not surround by the directives as its definition
>
>
>
>
> Date: 
>
> Tue, 25 Oct 2022 14:57:05 +0300
>
>
>
>
> > From: lin Sun <sunlin7.mail@gmail.com>
> > Date: Tue, 25 Oct 2022 05:32:09 +0000
> > 
> > Agree with you. And I had removed the directives that surround the
> > gflags.will_dump_ and the gflags.will_bootstrap_, then rebuilt emacs
> > with / without the dumper, it seems OK.
> > Please help review the patch. Thanks.
>
> Thanks, installed.
>
> Btw, you use both in your email and in the patch 2 different email
> accounts, none of which is recorded with your copyright assignment.
> This is confusing.  Could you please use one of the email addresses
> that are in your assignment?  TIA.
>
>
> --- End Message ---