bug#58405: closed ([PATCH] services: nginx: Add reload action)

[GNU bug Tracking System]

Your message dated Thu, 13 Oct 2022 12:38:14 +0100
with message-id <87wn946jh0.fsf@cbaines.net>
and subject line Re: [bug#58405] [PATCH] services: nginx: Add reload action
has caused the debbugs.gnu.org bug report #58405,
regarding [PATCH] services: nginx: Add reload action
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
58405: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58405
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] services: nginx: Add reload action
>
>
>
>
> Date: 
>
> Mon, 10 Oct 2022 01:39:32 -0300
>
>
>
>
> In a new "reload" shepherd-action, send a SIGHUP to the NGINX master
> process, so that it can re-read the configuration file and start new
> worker processes.
>
> * gnu/services/web.scm (nginx-shepherd-service): Add the "reload"
>   shepherd-action
> ---
>  gnu/services/web.scm | 15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/services/web.scm b/gnu/services/web.scm
> index e5ab1a1180..227a577de3 100644
> --- a/gnu/services/web.scm
> +++ b/gnu/services/web.scm
> @@ -807,7 +807,6 @@ (define (nginx-shepherd-service config)
>                            #~#t
>                            #~(read-pid-file #$pid-file))))))))
>  
> -     ;; TODO: Add 'reload' action.
>       (list (shepherd-service
>              (provision '(nginx))
>              (documentation "Run the nginx daemon.")
> @@ -815,7 +814,19 @@ (define (nginx-shepherd-service config)
>              (modules `((ice-9 match)
>                         ,@%default-modules))
>              (start (nginx-action "-p" run-directory))
> -            (stop (nginx-action "-s" "stop")))))))
> +            (stop (nginx-action "-s" "stop"))
> +            (actions
> +              (list
> +               (shepherd-action
> +                 (name 'reload)
> +                 (documentation "Reload NGINX configuration file and restart 
> worker processes.")
> +                 (procedure
> +                   #~(lambda (pid)
> +                       (if pid
> +                         (begin
> +                           (kill pid SIGHUP)
> +                           (format #t "Service NGINX (PID ~a) has been 
> reloaded." pid))
> +                         (format #t "Service NGINX is not running."))))))))))))
>  
>  (define nginx-service-type
>    (service-type (name 'nginx)
> -- 
> 2.37.3
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#58405] [PATCH] services: nginx: Add reload action Date: Thu, 13 Oct 2022 12:38:14 +0100 User-agent: mu4e 1.8.9; emacs 28.1

Christopher Baines <mail@cbaines.net> writes:

> I'm not quite sure how to address that, but I think this can still be
> merged.

I've gone ahead and pushed this as
10d429f2fce321d8285684503094694ec3979865.

Thanks,

Chris

signature.asc
Description: PGP signature

--- End Message ---