bug#58404: closed (29.0.50; [PATCH] When killing Emacs from the last client, don't warn about the session having clients)

[GNU bug Tracking System]

Your message dated Mon, 10 Oct 2022 16:09:08 -0700
with message-id <fa5194a5-a7ed-0549-ddc3-eb2c3fa9fc2c@gmail.com>
and subject line Re: bug#58404: 29.0.50; [PATCH] When killing Emacs from the 
last client, don't warn about the session having clients
has caused the debbugs.gnu.org bug report #58404,
regarding 29.0.50; [PATCH] When killing Emacs from the last client, don't warn 
about the session having clients
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
58404: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58404
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: 29.0.50; [PATCH] When killing Emacs from the last client, don't warn about the session having clients Date: Sun, 9 Oct 2022 16:32:28 -0700

To reproduce:

  $ emacs -Q --daemon
  $ emacsclient foo.txt

  M-x save-buffers-kill-emacs
  => This Emacs session has clients; exit anyway?

I think that's unnecessary. Since we're in the last (only) client, we can't accidentally kill other clients that we don't see right now (e.g. ones in an SSH connection); they don't exist! Couldn't we just proceed ahead without the prompt?

On the other hand, I think it *would* be useful to prompt if you're in the last client, but there are other non-client frames. This can happen if you start the main Emacs process without --daemon or if you use --no-wait. For example:

  $ emacs -Q --daemon
  $ emacsclient foo.txt
  $ emacsclient --no-wait -c bar.txt

  ;; From the first client:
  M-x save-buffers-kill-emacs
  => This Emacs session has clients; exit anyway?

This is ok, except the prompt could be clearer. The real issue is that the session has non-client frames that would get killed.

Attached is a patch to do this.

0001-Don-t-prompt-when-killing-an-Emacs-client-if-it-s-th.patch
Description: Text document

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#58404: 29.0.50; [PATCH] When killing Emacs from the last client, don't warn about the session having clients
>
>
>
>
> Date: 
>
> Mon, 10 Oct 2022 16:09:08 -0700
>
>
>
>
> On 10/10/2022 10:57 AM, Eli Zaretskii wrote:
> > > Date: Mon, 10 Oct 2022 10:49:05 -0700
> > > Cc: 58404@debbugs.gnu.org
> > > From: Jim Porter <jporterbugs@gmail.com>
> > >
> > > Attached is a new patch that removes the prompt when called from the
> > > last remaining client. I also expanded the docstring to explain why the
> > > prompt is there.
> >
> > LGTM, thanks.
>
> Thanks, merged as ebc19f56aaeb98b834eea1ce8768ca13bed8578c. Closing this 
> bug.
>
>
> --- End Message ---