bug#55661: closed (/etc/ssh/authorized_keys.d contains keys that have been removed)

[GNU bug Tracking System]

Your message dated Thu, 26 May 2022 17:20:34 +0200
with message-id <87tu9ce2wt.fsf@gnu.org>
and subject line Re: bug#55661: /etc/ssh/authorized_keys.d contains keys that 
have been removed
has caused the debbugs.gnu.org bug report #55661,
regarding /etc/ssh/authorized_keys.d contains keys that have been removed
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
55661: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55661
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> /etc/ssh/authorized_keys.d contains keys that have been removed
>
>
>
>
> Date: 
>
> Thu, 26 May 2022 17:02:00 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
>
>
>
>
> In the wake of <https://issues.guix.gnu.org/55359#3>, I realized that
> /etc/ssh/authorized_keys.d is stateful: we copy files from the
> authorized-key directory there, but files already present remain.
> IOW, keys remain authorized.
>
> Why are we copying that directory instead of making a symlink to the
> directory computed by ‘authorized-key-directory’ that’s in /gnu/store?
>
> This is explained in ‘openssh-activation’:
>
>         ;; 'sshd' complains if the authorized-key directory and its parents
>         ;; are group-writable, which rules out /gnu/store.  Thus we copy the
>         ;; authorized-key directory to /etc.
>
> Anyway, that code does intend remove the directory before copying it,
> but there’s a typo:
>
>   (delete-file-recursively "/etc/authorized_keys.d")
>
> Can you spot it?
>
> Ludo’.
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#55661: /etc/ssh/authorized_keys.d contains keys that have been removed
>
>
>
>
> Date: 
>
> Thu, 26 May 2022 17:20:34 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
>
>
>
>
> Ludovic Courtès <ludo@gnu.org> skribis:
>
> > Anyway, that code does intend remove the directory before copying it,
> > but there’s a typo:
> >
> >   (delete-file-recursively "/etc/authorized_keys.d")
>
> Fixed in 4577f3c6b60ea100e521c246fb169d6c05214b20.
>
> Ludo'.
>
>
> --- End Message ---