bug#55494: closed ([PATCH] daemon: runChild() is forbidden to talk during environment set up)

[GNU bug Tracking System]

Your message dated Thu, 19 May 2022 16:48:09 +0200
with message-id <87zgjdy3x2.fsf@gnu.org>
and subject line Re: bug#55494: [PATCH] daemon: runChild() is forbidden to talk 
during environment  set up
has caused the debbugs.gnu.org bug report #55494,
regarding [PATCH] daemon: runChild() is forbidden to talk during environment  
set up
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
55494: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55494
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] daemon: runChild() is forbidden to talk during environment  set up
>
>
>
>
> Date: 
>
> Tue, 17 May 2022 23:08:54 +0200 (CEST)
>
>
>
>
> DerivationGoal::startBuilder() is waiting for an empty line as a check that
> the environment set up is fine.
>
> Fixes <https://issues.guix.gnu.org/55324>
> ---
>  nix/libstore/build.cc | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/nix/libstore/build.cc b/nix/libstore/build.cc
> index f6431bb726..9305208009 100644
> --- a/nix/libstore/build.cc
> +++ b/nix/libstore/build.cc
> @@ -2057,7 +2057,6 @@ void DerivationGoal::runChild()
>                  Path source = i->second;
>                  Path target = chrootRootDir + i->first;
>                  if (source == "/proc") continue; // backwards compatibility
> -                debug(format("bind mounting `%1%' to `%2%'") % source % 
> target);
>                  if (stat(source.c_str(), &st) == -1)
>                      throw SysError(format("getting attributes of path `%1%'") 
> % source);
>                  if (S_ISDIR(st.st_mode))
> -- 
> 2.36.0
>
>
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#55494: [PATCH] daemon: runChild() is forbidden to talk during environment  set up
>
>
>
>
> Date: 
>
> Thu, 19 May 2022 16:48:09 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
>
>
>
>
> Hi,
>
> yarl-baudig@mailoo.org skribis:
>
> > DerivationGoal::startBuilder() is waiting for an empty line as a check that
> > the environment set up is fine.
> >
> > Fixes <https://issues.guix.gnu.org/55324>
>
> Oh, good catch!
>
> I tweaked the commit log and applied it.
>
> Thank you!
>
> Ludo’.
>
>
> --- End Message ---