emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#54933: closed ([patch] Add Liquid War 6)


From: GNU bug Tracking System
Subject: bug#54933: closed ([patch] Add Liquid War 6)
Date: Fri, 29 Apr 2022 21:15:01 +0000

Your message dated Fri, 29 Apr 2022 23:14:22 +0200
with message-id <87ilqr618x.fsf@gnu.org>
and subject line Re: bug#54933: [patch] Add Liquid War 6
has caused the debbugs.gnu.org bug report #54933,
regarding [patch] Add Liquid War 6
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
54933: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54933
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [patch] Add Liquid War 6 Date: Thu, 14 Apr 2022 07:00:29 -0300 (BRT)

Attachment: liquidwar6.diff
Description: Text Data


--- End Message ---
--- Begin Message --- Subject: Re: bug#54933: [patch] Add Liquid War 6 Date: Fri, 29 Apr 2022 23:14:22 +0200 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
Hi,

zamfofex <zamfofex@twdb.moe> skribis:

> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index de398c297f..8765f70761 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm

Applied with mostly cosmetic changes:

> +    (inputs
> +      (list guile-2.0 zlib expat sqlite ncurses readline curl doxygen 
> python-2
> +            libxslt perl graphviz glu libcaca
> +            (sdl-union (list sdl sdl-image sdl-ttf sdl-mixer))))

I passed it through ‘guix style’ and moved ‘doxygen’ to ‘native-inputs’
as suggested by ‘guix lint’.

> +    (arguments
> +      '(#:configure-flags
> +         (list
> +           "--enable-allinone"
> +           "CFLAGS=-Wno-error"
> +           (string-append "CPPFLAGS="
> +             "-I" (search-input-directory %build-inputs "include/SDL")))))

I used a gexp and ‘this-package-input’here.

> +    (description
> +      (string-append
> +        "Liquid War 6 is a unique multiplayer wargame. Your army is a blob 
> of "
> +        "liquid and you have to try and eat your opponents. Rules are very "
> +        "simple yet original, they have been invented by Thomas Colcombet."))

I changed that to a literal string:

  https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html

For future patches please take a look at:

  https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html

In particular, please use ‘git format-patch’ and possibly ‘git
send-email’ to send patches.  That ensures the commit log and authorship
are preserved and makes the reviewer’s life easier.  :-)

Thanks!

Ludo’.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]