bug#33729: closed (27.0.50; Partial glyphs not rendered for Gujarati with Harfbuzz enabled (renders fine using m17n))

[GNU bug Tracking System]

Your message dated Fri, 29 Apr 2022 16:24:05 +0300
with message-id <83r15g9g5m.fsf@gnu.org>
and subject line Re: bug#33729: 27.0.50; Partial glyphs not rendered for 
Gujarati with Harfbuzz enabled (renders fine using m17n)
has caused the debbugs.gnu.org bug report #33729,
regarding 27.0.50; Partial glyphs not rendered for Gujarati with Harfbuzz 
enabled (renders fine using m17n)
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
33729: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33729
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: 27.0.50; Partial glyphs not rendered for Gujarati with Harfbuzz enabled (renders fine using m17n) Date: Thu, 13 Dec 2018 15:20:23 -0500

Hello,

I built emacs from harfbuzz branch with harfbuzz 1.0.3 installed (RHEL 6.8).

I quickly compared Hindi and Gujarati rendering difference between emacs built with m17n vs the new harfbuzz branch build.

With harfbuzz, it does not render the partial glyphs for Gujarati, but does it fine for Hindi. But on the build with m17n, both Hindi and Gujarati show that partial glyph rendered fine.

Screenshot to explain this issue: https://i.imgtc.com/md9Yz7X.png

In GNU Emacs 27.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 2.24.23)
 of 2018-12-13
Repository revision: 981b3d292aff49452c2b5f0217b57ec1a2829a8b
Repository branch: harfbuzz
Windowing system distributor 'The X.Org Foundation', version 11.0.60900000
System Description: Red Hat Enterprise Linux Workstation release 6.8 (Santiago)

Recent messages:
Emacs version: GNU Emacs 27.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 2.24.23)
 of 2018-12-13, built using commit 981b3d292aff49452c2b5f0217b57ec1a2829a8b.

./configure options:
  --with-modules --prefix=/home/kmodi/usr_local/apps/6/emacs/harfbuzz '--program-transform-name=s/^ctags$/ctags_emacs/' --with-harfbuzz 'CPPFLAGS=-I/home/kmodi/stowed/include -I/home/kmodi/usr_local/6/include -I/usr/include/freetype2 -I/usr/include' 'CFLAGS=-O2 -march=native' 'LDFLAGS=-L/home/kmodi/stowed/lib -L/home/kmodi/stowed/lib64 -L/home/kmodi/usr_local/6/lib -L/home/kmodi/usr_local/6/lib64' PKG_CONFIG_PATH=/home/kmodi/usr_local/6/lib/pkgconfig:/home/kmodi/usr_local/6/lib64/pkgconfig:/cad/adi/apps/gnu/linux/x86_64/6/lib/pkgconfig:/cad/adi/apps/gnu/linux/x86_64/6/lib64/pkgconfig:/home/kmodi/stowed/lib/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig:/usr/share/pkgconfig:/lib/pkgconfig:/lib64/pkgconfig

Features:
  XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK2 X11 XDBE XIM MODULES THREADS GMP

Important settings:
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=none
  locale-coding-system: utf-8-unix

--
Kaushal Modi

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#33729: 27.0.50; Partial glyphs not rendered for Gujarati with Harfbuzz enabled (renders fine using m17n)
>
>
>
>
> Date: 
>
> Fri, 29 Apr 2022 16:24:05 +0300
>
>
>
>
> > From: Lars Ingebrigtsen <larsi@gnus.org>
> > Cc: Eli Zaretskii <eliz@gnu.org>,  behdad@behdad.org,
> >   far.nasiri.m@gmail.com,  33729@debbugs.gnu.org
> > Date: Fri, 29 Apr 2022 14:47:55 +0200
> > 
> > Khaled Hosny <dr.khaled.hosny@gmail.com> writes:
> > 
> > >> Thanks.  Do you see any difference in the results?
> > >
> > > Strings with forced direction (e.g. Arabic with LRO) showed difference.
> > > Without my change they were shaped RTL by drawn LTR, with my change
> > > shaping and drawing used LTR direction. Please feel free to revert that
> > > change if you think it is incorrect.
> > 
> > (I'm going through old bug reports that unfortunately weren't resolved
> > at the time.)
> > 
> > Skimming this long bug report, it seems like the fixes Khaled pushed
> > fixed the reported issue (but I may well be misreading).
> > 
> > Eli, is there anything more to do here?
>
> No.  The original problem was fixed, and a couple of followup issues
> were also fixed.
>
> So I'm closing this bug.
>
>
> --- End Message ---