bug#54713: closed ([PATCH] gnu: linux: Allow kconfig options to be strings)

[GNU bug Tracking System]

Your message dated Tue, 05 Apr 2022 20:18:38 +0200
with message-id <87pmlvjsw1.fsf@gnu.org>
and subject line Re: bug#54713: [PATCH] gnu: linux: Allow kconfig options to be 
strings
has caused the debbugs.gnu.org bug report #54713,
regarding [PATCH] gnu: linux: Allow kconfig options to be strings
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
54713: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=54713
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: linux: Allow kconfig options to be strings
>
>
>
>
> Date: 
>
> Mon,  4 Apr 2022 11:26:09 -0700
>
>
>
>
> * gnu/packages/linux.scm (config->string): add a clause handling strings
>
> Allows for the declarative configuration of kconfig options which accept
> strings, such as CONFIG_MODULE_SIG_KEY.
>
> I've enclosed the given string in quotes, but don't do any kind of
> escaping. See the kernel mailing list for the current state of escaped
> strings upstream:
>
> https://patchwork.kernel.org/project/linux-kbuild/patch/1431003982-992-1-git-send-email-sr@denx.de/
>
> Apologies to those with double-quotes or backslashes in their
> CONFIG_SYSTEM_*_KEYS.
>
> Signed-off-by: antlers <autumnalantlers@gmail.com>
> ---
>  gnu/packages/linux.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index ec68f5c57e..9a81fc4a3d 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -767,7 +767,9 @@ (define (config->string options)
>                        ((option . #t)
>                         (string-append option "=y"))
>                        ((option . #f)
> -                       (string-append option "=n")))
> +                       (string-append option "=n"))
> +                      ((option . string)
> +                       (string-append option "=\"" string "\"")))
>                      options)
>                 "\n"))
>  
> -- 
> 2.34.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#54713: [PATCH] gnu: linux: Allow kconfig options to be strings
>
>
>
>
> Date: 
>
> Tue, 05 Apr 2022 20:18:38 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
>
>
>
>
> Hi,
>
> antlers <autumnalantlers@gmail.com> skribis:
>
> > * gnu/packages/linux.scm (config->string): add a clause handling strings
> >
> > Allows for the declarative configuration of kconfig options which accept
> > strings, such as CONFIG_MODULE_SIG_KEY.
> >
> > I've enclosed the given string in quotes, but don't do any kind of
> > escaping. See the kernel mailing list for the current state of escaped
> > strings upstream:
> >
> > https://patchwork.kernel.org/project/linux-kbuild/patch/1431003982-992-1-git-send-email-sr@denx.de/
> >
> > Apologies to those with double-quotes or backslashes in their
> > CONFIG_SYSTEM_*_KEYS.
>
> Applied.
>
> If needed, a cheap and often “good enough” way to escape strings is
> ‘object->string’:
>
>   (display (object->string "foo\"bar\"baz"))
>   => "foo\"bar\"baz"
>
> Would that help here?
>
> Thanks,
> Ludo’.
>
>
> --- End Message ---