bug#54521: closed ([PATCH] dircolors: colorize backup files with bright black)

[GNU bug Tracking System]

Your message dated Sun, 3 Apr 2022 21:24:41 +0100
with message-id <fe581ff5-2232-0cf9-f1ad-3462d49eea82@draigBrady.com>
and subject line Re: bug#54521: [PATCH] dircolors: colorize backup files with 
bright black
has caused the debbugs.gnu.org bug report #54521,
regarding [PATCH] dircolors: colorize backup files with bright black
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
54521: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=54521
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] dircolors: colorize backup files with bright black
>
>
>
>
> Date: 
>
> Tue, 22 Mar 2022 20:24:27 +0200
>
>
>
>
> Useful as it makes them stand out less than non-backup files.
> ---
>  src/dircolors.hin | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>
> diff --git a/src/dircolors.hin b/src/dircolors.hin
> index 673835201..6dc5a2d74 100644
> --- a/src/dircolors.hin
> +++ b/src/dircolors.hin
> @@ -211,5 +211,24 @@ EXEC 01;32
>  .spx 00;36
>  .xspf 00;36
>  
> +# backup files
> +*~ 00;90
> +*# 00;90
> +.bak 00;90
> +.old 00;90
> +.orig 00;90
> +.part 00;90
> +.rej 00;90
> +.swp 00;90
> +.tmp 00;90
> +.dpkg-dist 00;90
> +.dpkg-old 00;90
> +.ucf-dist 00;90
> +.ucf-new 00;90
> +.ucf-old 00;90
> +.rpmnew 00;90
> +.rpmorig 00;90
> +.rpmsave 00;90
> +
>  # Subsequent TERM or COLORTERM entries, can be used to add / override
>  # config specific to those matching environment variables.
> -- 
> 2.25.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#54521: [PATCH] dircolors: colorize backup files with bright black
>
>
>
>
> Date: 
>
> Sun, 3 Apr 2022 21:24:41 +0100
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64; rv:97.0) Gecko/20100101 Thunderbird/97.0
>
>
>
>
> On 23/03/2022 23:53, Pádraig Brady wrote:
> > On 22/03/2022 18:24, Ville Skyttä wrote:
> > > Useful as it makes them stand out less than non-backup files.
> > > ---
> > >    src/dircolors.hin | 19 +++++++++++++++++++
> > >    1 file changed, 19 insertions(+)
> > >
> > > diff --git a/src/dircolors.hin b/src/dircolors.hin
> > > index 673835201..6dc5a2d74 100644
> > > --- a/src/dircolors.hin
> > > +++ b/src/dircolors.hin
> > > @@ -211,5 +211,24 @@ EXEC 01;32
> > >    .spx 00;36
> > >    .xspf 00;36
> > >    
> > > +# backup files
> > > +*~ 00;90
> > > +*# 00;90
> > > +.bak 00;90
> > > +.old 00;90
> > > +.orig 00;90
> > > +.part 00;90
> > > +.rej 00;90
> > > +.swp 00;90
> > > +.tmp 00;90
> > > +.dpkg-dist 00;90
> > > +.dpkg-old 00;90
> > > +.ucf-dist 00;90
> > > +.ucf-new 00;90
> > > +.ucf-old 00;90
> > > +.rpmnew 00;90
> > > +.rpmorig 00;90
> > > +.rpmsave 00;90
> > > +
> > >    # Subsequent TERM or COLORTERM entries, can be used to add / override
> > >    # config specific to those matching environment variables.
> >
> > I quite like that actually.
> > The default coloring works well on both dark and light backgrounds.
> > Coloring this class of files does seem useful.
> >
> > +1 from me anyway.
>
> I've pushed this after some perf testing showing it had negligible perf impact.
> https://git.sv.gnu.org/cgit/coreutils.git/commit/?id=52aeae2c3
>
> Here is a small example of the output:
> https://www.pixelbeat.org/patches/coreutils/ls-backup-colors.html
>
> cheers,
> Pádraig
>
>
> --- End Message ---