emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#54201: closed ([PATCH] Add wego)


From: GNU bug Tracking System
Subject: bug#54201: closed ([PATCH] Add wego)
Date: Sat, 19 Mar 2022 00:00:02 +0000

Your message dated Sat, 19 Mar 2022 00:59:09 +0100
with message-id <87ilsau81e.fsf@nicolasgoaziou.fr>
and subject line Re: bug#54201: [PATCH] Add wego
has caused the debbugs.gnu.org bug report #54201,
regarding [PATCH] Add wego
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
54201: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=54201
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [PATCH] Add wego Date: Tue, 01 Mar 2022 01:29:35 +0100 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
Hello,

The following two patches add wego. I create a new "weather.scm" file
since I didn't know where to put it.

Regards,
-- 
Nicolas Goaziou

Attachment: 0001-gnu-Add-go-github-com-schachmat-ingo.patch
Description: Add go-github-com-schachmat-ingo

Attachment: 0002-gnu-Add-wego.patch
Description: Add wego


--- End Message ---
--- Begin Message --- Subject: Re: bug#54201: [PATCH] Add wego Date: Sat, 19 Mar 2022 00:59:09 +0100 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
Hello,

Ludovic Courtès <ludo@gnu.org> writes:

> Nicolas Goaziou <mail@nicolasgoaziou.fr> skribis:

>> +++ b/gnu/packages/weather.scm
>> @@ -0,0 +1,34 @@
>> +(define-module (gnu packages weather)
>
> Please add a license header.

Done.

>> +    (description "@strong{wego} is a weather client for the terminal.")
>
> Could you expound a little bit, mentioning key features, etc.?
>
> You can prolly remove @strong.

Done.

>> +    (license isc)))
>
> Perhaps #:prefix license: ?

I thought we needed to use the prefix only when there was a conflict in
the module.

Anyhow, done.

> Otherwise LGTM, thanks!

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]