bug#50299: closed (The check-tests-true lint check is incorrect for Emacs packages)

[GNU bug Tracking System]

Your message dated Fri, 11 Mar 2022 23:43:38 -0500
with message-id <87k0czsrut.fsf_-_@gmail.com>
and subject line Re: bug#50299: The check-tests-true lint check is incorrect 
for Emacs packages
has caused the debbugs.gnu.org bug report #50299,
regarding The check-tests-true lint check is incorrect for Emacs packages
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
50299: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=50299
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> The check-tests-true lint check is incorrect for Emacs packages
>
>
>
>
> Date: 
>
> Tue, 31 Aug 2021 11:25:35 -0400
>
>
>
>
> Hi,
>
> The emacs-build-system has its #:tests? argument set to #f by default,
> which means users must explicitly specify its value as #t to enable test
> suites.
>
> The check-tests-true lint check seems to ignore this and goes on to
> recommend, for example:
>
> --8<---------------cut here---------------start------------->8---
> gnu/packages/emacs-xyz.scm:15998:7: emacs-groovy-modes@2.0-0.99eaf70: #:tests? 
> must not be explicitly set to #t
> --8<---------------cut here---------------end--------------->8---
>
> which is wrong.
>
> Thanks,
>
> Maxim
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#50299: The check-tests-true lint check is incorrect for Emacs packages
>
>
>
>
> Date: 
>
> Fri, 11 Mar 2022 23:43:38 -0500
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
>
>
>
>
> Hi Maxime,
>
> Maxime Devos <maximedevos@telenet.be> writes:
>
> > This is the v4 patch, rebased.  No other changes.
>
> I've tried to getting rid of as many lint warnings I could on each
> package touched, got rid of the python2* packages touched, and squashed
> many same-package/scope changes together.
>
> Note that the latest available version of swi-prolog builds and test
> fine, but fails to be cross-compiled, so I've left it as is; you may
> want to investigate the upgrade.
>
> Thank you,
>
> Closing.
>
> Maxim
>
>
> --- End Message ---