bug#54291: closed (zdiff can not handle options properly)

[GNU bug Tracking System]

Your message dated Mon, 7 Mar 2022 09:44:06 -0800
with message-id <5d0e0627-aec9-2ee1-93fc-6d269c9f33de@cs.ucla.edu>
and subject line Re: bug#54291: zdiff can not handle options properly
has caused the debbugs.gnu.org bug report #54291,
regarding zdiff can not handle options properly
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
54291: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=54291
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> zdiff can not handle options properly
>
>
>
>
> Date: 
>
> Mon, 7 Mar 2022 17:32:45 +0800
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1
>
>
>
>
> As Bram Mertens mentioned in bug#35209:
> "diff -y -W 200 /tmp/b1 /tmp/b2". But when passed to zdiff the space 
> between "-W" and 200 causes the COLUMNS argument to be interpreted as a 
> file:
> zdiff -y -W 200 /tmp/b1 /tmp/b2
> /bin/zdiff: 72: /bin/zdiff: cannot open 200: No such file
>
> I reproduce this problem in gzip 1.11:
> zdiff -y -W200 a.gz b.gz
> aaaa                            |    bbbb
> zdiff -y -W 200 a.gz b.gz
> zdiff: line 66: 200: No such file or directory
>
> Also, file before options is not supported:
> zdiff a.gz b.gz -y -W200
> zdiff: line 66: -y: No such file or directory
> diff a b -y -W 200
> aaaa                            |    bbbb
>
> This is because zdiff.in implement option parse is simple. zdiff.in 
> first parse all the options by while loop.
> The use cmp="$cmp --" sperate options and file arguments. It is 
> understandable that zdiff does not want to repeat the parameter parsing 
> work of diff. So, use the simple option parse here.
>
> However, the usage string said "Do comparisons like 'diff' does." Such 
> usage will misldead the user just as bug#35209 mentioned.
>
> There are two suggestions we may discuss:
> 1. update usage string, add detailed restricted instructions: e.g NO 
> space between option and option argument, all the options should come 
> before the filename parameter.
> 2. rewrite options parse function make it work just like diff.
>
> --
> Thanks!
> Lv Ying
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: bug#54291: zdiff can not handle options properly Date: Mon, 7 Mar 2022 09:44:06 -0800 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0

On 3/7/22 01:32, Lv Ying via GNU gzip discussion and bug reports. wrote:

2. rewrite options parse function make it work just like diff.

Thanks for reporting the problem. I installed the attached to implement the above suggestion, and this should appear in the next gzip release.

0001-zdiff-fix-arg-handling-bug.patch
Description: Text Data

--- End Message ---