bug#54151: closed (gnu: Add #:log-file option when starting openvpn shepherd services)

[GNU bug Tracking System]

Your message dated Thu, 03 Mar 2022 23:32:52 +0100
with message-id <878rtqvf8r.fsf@gnu.org>
and subject line Re: bug#54151: gnu: Add #:log-file option when starting 
openvpn shepherd services
has caused the debbugs.gnu.org bug report #54151,
regarding gnu: Add #:log-file option when starting openvpn shepherd services
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
54151: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=54151
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: gnu: Add #:log-file option when starting openvpn shepherd services Date: Thu, 24 Feb 2022 16:23:47 -0600

I accidentally submitted this to bug-guix, first, sorry.

---------- Forwarded message ---------
From: Cameron Chaparro <cameron@cameronchaparro.com>
Date: Thu, Feb 24, 2022 at 4:11 PM
Subject: openvpn-shepherd-service is not writing log files
To: <bug-guix@gnu.org>

I noticed that the `openvpn-shepherd-service' is defining, but not
actually using, the log file when starting the client/server. I think
this patch should address that issue.

Cameron Chaparro

0001-gnu-Add-log-file-option-when-starting-openvpn-shephe.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#54151: gnu: Add #:log-file option when starting openvpn shepherd services
>
>
>
>
> Date: 
>
> Thu, 03 Mar 2022 23:32:52 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
>
>
>
>
> Hi,
>
> Cameron Chaparro <cameron@cameronchaparro.com> skribis:
>
> > +++ b/gnu/services/vpn.scm
> > @@ -9,6 +9,7 @@
> >  ;;; Copyright © 2021 Raghav Gururajan <rg@raghavgururajan.name>
> >  ;;; Copyright © 2021 jgart <jgart@dismail.de>
> >  ;;; Copyright © 2021 Nathan Dehnel <ncdehnel@gmail.com>
> > +;;; Copyright © 2022 Cameron V Chaparro <cameron@cameronchaparro.com>
> >  ;;;
> >  ;;; This file is part of GNU Guix.
> >  ;;;
> > @@ -494,7 +495,8 @@ (define (openvpn-shepherd-service role)
> >                         (list (string-append #$openvpn "/sbin/openvpn")
> >                               "--writepid" #$pid-file "--config" #$config-file
> >                               "--daemon")
> > -                       #:pid-file #$pid-file))
> > +                       #:pid-file #$pid-file
> > +                       #:log-file #$log-file))
> >               (stop #~(make-kill-destructor)))))))
>
> I adjusted the commit log and applied it, thanks!
>
> Ludo’.
>
>
> --- End Message ---