bug#53859: closed ([PATCH] gnu: clojure-data-xml: Fix build by removing tests.)

[GNU bug Tracking System]

Your message dated Tue, 8 Feb 2022 11:55:49 +0100
with message-id <20220208115549.71b1c7fa@tachikoma.lepiller.eu>
and subject line Re: [bug#53860] [PATCH] gnu: clojure-data-xml: Fix build by 
removing tests.
has caused the debbugs.gnu.org bug report #53860,
regarding [PATCH] gnu: clojure-data-xml: Fix build by removing tests.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
53860: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=53860
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: clojure-data-xml: Fix build by removing tests.
>
>
>
>
> Date: 
>
> Mon,  7 Feb 2022 19:32:18 +0000
>
>
>
>
> Hi,
>
> New versions of clojure-tools are blocked by clojure-data-xml failing to
> build. This is caused by the tests being out of date and not runnable
> under recent JDKs [0]
>
> The attached patch prevents all tests running, so the build runs. It
> works, but doesn't seem optimal - though may be the best option until
> upstream resolves?
>
> Thanks,
>
> Futurile
>
>
> [0] 
> https://ask.clojure.org/index.php/11546/clojure-data-xml-tests-fail-on-jdk-17 
> and https://clojure.atlassian.net/browse/DXML-67
>
>
>
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#53860] [PATCH] gnu: clojure-data-xml: Fix build by removing tests.
>
>
>
>
> Date: 
>
> Tue, 8 Feb 2022 11:55:49 +0100
>
>
>
>
> Le Mon,  7 Feb 2022 19:32:19 +0000,
> Steve George <steve@futurile.net> a écrit :
>
> > * gnu/packages/clojure.scm (clojure-data-xml): tests don't work with
> > stable and recent versions of the JDK
> > (https://clojure.atlassian.net/browse/DXML-67). Prevent test build
> > stage running. ---
> >  gnu/packages/clojure.scm | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> > 
> > diff --git a/gnu/packages/clojure.scm b/gnu/packages/clojure.scm
> > index 40a3d7708a..6f9dbd6bca 100644
> > --- a/gnu/packages/clojure.scm
> > +++ b/gnu/packages/clojure.scm
> > @@ -333,10 +333,13 @@ is on par with Java implementations, e.g.,
> > Apache commons-codec.") (arguments
> >       '(#:source-dirs '("src/main/clojure")
> >         #:test-dirs '("src/test/clojure")
> > -       #:doc-dirs '()))
> > +       #:doc-dirs '()
> > +       ;; FIXME: resolve when
> > https://clojure.atlassian.net/browse/DXML-67 is closed
> > +       #:tests? #f))
> >      (propagated-inputs (list clojure-data-codec))
> >      (synopsis "Clojure library for reading and writing XML data")
> > -    (description "@code{data.xml} is a Clojure library for reading
> > and writing
> > +    (description
> > +     "@code{data.xml} is a Clojure library for reading and writing
> >  XML data. @code{data.xml} has the following features:
> >  
> >  Parses XML documents into Clojure data structures
> > 
> > base-commit: abb197dfe98095a9ea7527a3ca3f81bb0edd5813
>
> Thanks for the patch! Ryan had a better approach in
> https://issues.guix.gnu.org/53868, so I pushed it instead. Disabling
> only the failing test is better that disabling all tests :).
>
> Closing this as the package is now fixed. Thanks!
>
>
> --- End Message ---