bug#53427: closed (perror should not errcnt across test files)

[GNU bug Tracking System]

Your message dated Mon, 24 Jan 2022 20:44:14 -0600
with message-id <61EF63FE.60403@gmail.com>
and subject line Re: bug#53427: perror should not errcnt across test files
has caused the debbugs.gnu.org bug report #53427,
regarding perror should not errcnt across test files
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
53427: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=53427
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: perror should not errcnt across test files Date: Fri, 21 Jan 2022 22:02:08 +0100 User-agent: NeoMutt/20180716

There seems to be an old bug originally reported in the Red Hat
bug tracker [1] still present in the dejagnu 1.6.3 sources.
Steps to Reproduce:


echo 'perror foo' >a.exp; echo 'pass bar' >b.exp; runtest a.exp b.exp; cat 
testrun.sum

Actual results:
...
Running target unix
Running ./a.exp ...
ERROR: foo
Running ./b.exp ...
UNRESOLVED: bar

                ===  Summary ===
...

Expected results:
...
Running target unix
Running ./a.exp ...
ERROR: foo
Running ./b.exp ...
PASS: bar

                ===  Summary ===
...


Patch attached.  Please consider fixing.

Thanks,
Martin



-------
[1] https://bugzilla.redhat.com/show_bug.cgi?id=460153

dejagnu-1.6.3-perror-across-test-files.patch
Description: Text document

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#53427: perror should not errcnt across test files
>
>
>
>
> Date: 
>
> Mon, 24 Jan 2022 20:44:14 -0600
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.22) Gecko/20090807 MultiZilla/1.8.3.4e SeaMonkey/1.1.17 Mnenhy/0.7.6.0
>
>
>
>
> Martin Cermak wrote:
> > On  Fri  2022-01-21  21:26 , Jacob Bachmeyer wrote:
> >   
> > > Martin Cermak wrote:
> > >     
> > > > There seems to be an old bug originally reported in the Red Hat
> > > > bug tracker [1] still present in the dejagnu 1.6.3 sources.
> > > > Steps to Reproduce:
> > > >
> > > >
> > > > echo 'perror foo' >a.exp; echo 'pass bar' >b.exp; runtest a.exp b.exp; cat 
> > > > testrun.sum
> > > >
> > > > Actual results:
> > > > [...]
> > > >
> > > > Patch attached.  Please consider fixing.
> > > >       
> > > A regression test and fix has been pushed to Savannah on the PR53427 branch,
> > > as of commit c5964e8fa2a8c3657cd6f6fef63d43451eedac7d.
> > >
> > > The supplied patch would have also zeroed the per-target test counts between
> > > test files, so it was not usable.  A more-direct solution was applied.
> > >
> > > Please confirm that this resolves the issue with whatever system originally
> > > encountered this bug, if possible.  If so, I will merge the branch and this
> > > will be fixed in 1.6.4.
> > >     
> >
> >
> > Jacob, your patch seems to work for me.
>
> Merged; the patch has landed for 1.6.4.
>
> -- Jacob
>
>
>
> --- End Message ---