bug#52763: closed ([PATCH] etc: Match define-public only at line start.)

[GNU bug Tracking System]

Your message dated Wed, 19 Jan 2022 21:17:42 +0100
with message-id <9bfeededaa923fca6f7960839caa1a465450a392.camel@gmail.com>
and subject line Re: bug#52763: [PATCH] etc: Match define-public only at line 
start.
has caused the debbugs.gnu.org bug report #52763,
regarding [PATCH] etc: Match define-public only at line start.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
52763: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=52763
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] etc: Match define-public only at line start.
>
>
>
>
> Date: 
>
> Fri, 24 Dec 2021 01:33:14 +0100
>
>
>
>
> The current regexp simply matches the first occurence, which more often than
> not points to the *previous* variable.
>
> * etc/snippets/text-mode/guix-commit-message-update-package ($1): Restrict
> match to beginning of line with optional indentation.
> ---
>  etc/snippets/text-mode/guix-commit-message-update-package | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/etc/snippets/text-mode/guix-commit-message-update-package 
> b/etc/snippets/text-mode/guix-commit-message-update-package
> index f187419aa2..b08df74a0b 100644
> --- a/etc/snippets/text-mode/guix-commit-message-update-package
> +++ b/etc/snippets/text-mode/guix-commit-message-update-package
> @@ -8,7 +8,7 @@ gnu: ${1:`(with-temp-buffer
>             (magit-git-wash #'magit-diff-wash-diffs
>               "diff" "--staged")
>             (goto-char (point-min))
> -           (when (re-search-forward "(define-public \\(\\S-+\\)" nil 'noerror)
> +           (when (re-search-forward "^[ ]*(define-public \\(\\S-+\\)" nil 
> 'noerror)
>               (match-string-no-properties 1)))`}: Update to 
> ${2:`(with-temp-buffer
>      (magit-git-wash #'magit-diff-wash-diffs
>        "diff" "--staged")
> -- 
> 2.34.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#52763: [PATCH] etc: Match define-public only at line start.
>
>
>
>
> Date: 
>
> Wed, 19 Jan 2022 21:17:42 +0100
>
>
>
>
> User-agent: 
>
> Evolution 3.42.1 
>
>
>
>
> Am Mittwoch, dem 05.01.2022 um 23:25 +0100 schrieb Ludovic Courtès:
> > Hi,
> > 
> > Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:
> > 
> > > The current regexp simply matches the first occurence, which more
> > > often than not points to the *previous* variable.
> > > 
> > > * etc/snippets/text-mode/guix-commit-message-update-package ($1):
> > > Restrict match to beginning of line with optional indentation.
> > 
> > LGTM, thanks!
> The manual says 14 days after no review, not 14 days after review. 
> Pushed now :)
>
>
> --- End Message ---