bug#53048: closed (28.0.90; [PATCH] GNU ELPA local build fails silently on macOS)

[GNU bug Tracking System]

Your message dated Sun, 9 Jan 2022 07:25:22 -0600
with message-id 
<CADwFkmm2AqThQQnrfL7fYUoyVHzArMpm1ezfA=ojELjN-HOmCg@mail.gmail.com>
and subject line Re: bug#53048: 28.0.90; [PATCH] GNU ELPA local build fails 
silently on macOS
has caused the debbugs.gnu.org bug report #53048,
regarding 28.0.90; [PATCH] GNU ELPA local build fails silently on macOS
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
53048: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=53048
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: 28.0.90; [PATCH] GNU ELPA local build fails silently on macOS Date: Thu, 06 Jan 2022 12:35:41 +0200

On macOS, with the default 'bsdtar', 'make build/<pkg>' fails to create
a tarball, but does not warn about it, outputting:

> ======== Building tarball archive-devel/<pkg-vers>.tar...
> ######## Built new package archive-devel/<pkg-vers>.tar!
> ======== Building tarball archive/<pkg-ver>.tar...
> ######## Built new package archive/<pkg-ver>.tar!

['bsdtar' does not expose '--transform' option. Though it provides a
similar '-s' option with a bit different syntax.]

This patch suggests asserting a tarball was generated. This would
result in a more helpful output on a failed generation:

> ======== Building tarball archive-devel/<pkg-vers>.tar...
> Build error for archive-devel/<pkg-vers>.tar: (cl-assertion-failed 
> (file-readable-p tarball))
> ######## Build of package archive-devel/<pkg-vers>.tar FAILED!!
> ======== Building tarball archive/<pkg-ver>.tar...
> Build error for archive/<pkg-ver>.tar: (cl-assertion-failed (file-readable-p 
> tarball))
> ######## Build of package archive/<pkg-ver>.tar FAILED!!



In GNU Emacs 28.0.90 (build 1, x86_64-apple-darwin21.1.0, NS appkit-2113.00 
Version 12.0.1 (Build 21A559))

0001-admin-elpa-admin.el-elpaa-make-one-tarball-1-Assert-.patch
Description: Assert tarball exists

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#53048: 28.0.90; [PATCH] GNU ELPA local build fails silently on macOS
>
>
>
>
> Date: 
>
> Sun, 9 Jan 2022 07:25:22 -0600
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
>
>
>
>
> Y. E. <yet@ego.team> writes:
>
> > From b8ce44d9f3da636a9236d7fc6a29dffb73d819ec Mon Sep 17 00:00:00 2001
> > From: YugaEgo <yet@ego.team>
> > Date: Thu, 6 Jan 2022 11:55:27 +0200
> > Subject: [PATCH] * admin/elpa-admin.el (elpaa--make-one-tarball-1): Assert
> >  tarball exists
> >
> > ---
> >  elpa-admin.el | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/elpa-admin.el b/elpa-admin.el
> > index b4ad318ef6..d94cc7fd73 100644
> > --- a/elpa-admin.el
> > +++ b/elpa-admin.el
> > @@ -612,6 +612,7 @@ auxillary files unless TARBALL-ONLY is non-nil ."
> >                ,(format "s|^packages/%s|%s-%s|" pkgname pkgname vers)
> >                "-chf" ,tarball
> >                ,(concat "packages/" pkgname)))
> > +     (cl-assert (file-readable-p tarball))
> >       (unless tarball-only
> >         (let* ((pkgdesc
> >                 ;; FIXME: `elpaa--write-pkg-file' wrote the metadata to
>
> Makes sense, pushed as commit 102694997e.
>
> Thanks for the patch!
>
>
> --- End Message ---