--- Begin Message ---
|
Subject: |
29.0.50; Customize Group INS buttons sometimes don't have a left box line |
|
Date: |
Mon, 01 Nov 2021 21:52:17 +0800 |
Run emacs -Q. Do M-x customize-group RET files RET, expand "After Save
Hook", then click "INS" twice. The second INS button will not have a
left box line, which is visually inconsistent with the first, and with
how buttons work in general across all X-Windows applications.
The repository branch used is not relevant here, it can also be
reproduced in master and emacs-28.
Thanks.
In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo
version 1.17.4)
of 2021-11-01 built on limity
Repository branch: x-window-xwidget
Windowing system distributor 'The X.Org Foundation', version 11.0.12101002
System Description: Fedora 34 (Workstation Edition)
Configured using:
'configure --with-xwidgets'
Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
LCMS2 LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG
RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM
XPM XWIDGETS GTK3 ZLIB
Important settings:
value of $LANG: en_GB.UTF-8
value of $XMODIFIERS: @im=ibus
locale-coding-system: utf-8-unix
Major mode: Custom
Minor modes in effect:
shell-dirtrack-mode: t
tooltip-mode: t
global-eldoc-mode: t
show-paren-mode: t
electric-indent-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
indent-tabs-mode: t
transient-mark-mode: t
Load-path shadows:
None found.
Features:
(shadow sort mail-extr emacsbug message rmc puny rfc822 mml mml-sec epa
derived gnus-util rmail rmail-loaddefs text-property-search mm-decode
mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader
sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
shadowfile tramp tramp-loaddefs trampver tramp-integration files-x
tramp-compat shell pcomplete parse-time iso8601 time-date ls-lisp
format-spec auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs
password-cache json map recentf tree-widget plstore epg rfc6068
epg-config latexenc filecache dired dired-loaddefs autorevert filenotify
autoinsert seq gv subr-x byte-opt bytecomp byte-compile cconv ange-ftp
comint ansi-color ring cus-edit pp cus-start cus-load wid-edit help-mode
cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify
ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button
loaddefs faces cus-face macroexp files window text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote threads xwidget-internal dbusbind
inotify lcms2 dynamic-setting system-font-setting font-render-setting
cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs)
Memory information:
((conses 16 100745 13815)
(symbols 48 10589 1)
(strings 32 32135 2089)
(string-bytes 1 1038099)
(vectors 16 19747)
(vector-slots 8 238756 13660)
(floats 8 41 129)
(intervals 56 635 172)
(buffers 992 13))
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#51550: 29.0.50; Customize Group INS buttons sometimes don't have a left box line |
|
Date: |
Thu, 30 Dec 2021 19:43:44 +0800 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Po Lu <luangruo@yahoo.com>
>> Cc: stefan@marxist.se, stephen.berman@gmx.net, 51550@debbugs.gnu.org
>> Date: Wed, 29 Dec 2021 21:54:38 +0800
>>
>> (with-current-buffer (get-buffer-create "*test*")
>> (insert #("foo\nfoo" 0 4 (face widget-field)))
>> (let ((overlay (make-overlay 5 8 nil t nil)))
>> (overlay-put overlay 'before-string (propertize " " 'invisible t))
>> (overlay-put overlay 'face custom-button)))
>>
>> After this, I would have expected the second "foo" in *test* to begin
>> with a box line, but it doesn't.
>
> It was a subtle bug in how we handle face's box attribute when the
> display engine changes the object on which it iterates. Compare the
> effect of this:
>
> (with-current-buffer (get-buffer-create "*test*")
> (load "wid-edit")
> (load "cus-edit")
> (insert #("foo\nfoo" 0 4 (face widget-field)))
> (let ((overlay (make-overlay 5 8 nil t nil)))
> (overlay-put overlay 'before-string "X")
> (overlay-put overlay 'face custom-button)))
>
> with this:
>
> (with-current-buffer (get-buffer-create "*test*")
> (load "wid-edit")
> (load "cus-edit")
> (insert #("foo\nXfoo" 0 4 (face widget-field)))
> (let ((overlay (make-overlay 6 9 nil t nil)))
> (overlay-put overlay 'face custom-button)))
>
> The change of face between the "X" and the following button should be
> displayed the same, but wasn't.
>
> I installed a fix on master. Please see if it solves the real-life
> use case, and close the bug if it does.
Yes, that fixes the problem. I'll push the corresponding fix to the
custom widget code, and I'm closing this bug. Thanks.
--- End Message ---