bug#52803: closed ([PATCH] gnu: Add headsetcontrol.)

[GNU bug Tracking System]

Your message dated Mon, 27 Dec 2021 10:49:57 +0100
with message-id <87h7au9y2i.fsf@nicolasgoaziou.fr>
and subject line Re: [bug#52803] [PATCH v2] gnu: Add headsetcontrol.
has caused the debbugs.gnu.org bug report #52803,
regarding [PATCH] gnu: Add headsetcontrol.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
52803: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=52803
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] gnu: Add headsetcontrol. Date: Sun, 26 Dec 2021 16:16:13 +0000

Attached is a patch to add the program headsetcontrol, which allows 
getting/setting properties for USB headsets. I've been using a previous version 
(2.4) locally for quite some time and it works well.

The package also builds udev rules, should a note be added to the description 
that it includes udev rules or anything about that?

Thanks!

John

0001-gnu-Add-headsetcontrol.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#52803] [PATCH v2] gnu: Add headsetcontrol.
>
>
>
>
> Date: 
>
> Mon, 27 Dec 2021 10:49:57 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
>
>
>
>
> Hello,
>
> John Kehayias via Guix-patches via <guix-patches@gnu.org> writes:
>
> > Subject: [PATCH] gnu: Add headsetcontrol.
> >
> > * gnu/packages/hardware.scm (headsetcontrol): New variable.
>
> Thank you. I pushed it with the changes detailed below.
>
> > +(define-public headsetcontrol
> > +  (package
> > +    (name "headsetcontrol")
> > +    (version "2.6")
> > +    (source (origin
> > +             (method git-fetch)
>
> I moved `origin' below `source' and adjusted indentation.
>
> > +             (uri (git-reference
> > +                   (url "https://github.com/Sapd/HeadsetControl";)
> > +                   (commit version)))
> > +             (file-name (git-file-name name version))
> > +             (sha256
> > +              (base32
> > +               "0a7zimzi71416pmn6z0l1dn1c2x8p702hkd0k6da9rsznff85a88"))))
>
> I moved hash on the same line as `base32'
>
> > +    (build-system cmake-build-system)
> > +    (inputs
> > +      (list hidapi))
> > +    (synopsis "Sidetone and Battery status for USB headsets")
> > +    (description
> > +      "A tool to control certain aspects of USB-connected headsets on Linux.
>
> I started the description with the name of the package (guix lint
> should warn you about this), and removed reference to Linux, since it is
> not useful in Guix.
>
> > +Currently, support is provided for adjusting sidetone, getting battery state,
> > +controlling LEDs, and setting the inactive time.")
> > +    (home-page "https://github.com/Sapd/HeadsetControl";)
> > +    (license license:gpl3)))
>
> I used gpl3+ as "main.c" includes "or (at your option) any later
> version" in its header.
>
> Regards,
> -- 
> Nicolas Goaziou
>
>
> --- End Message ---