bug#52247: closed ([PATCH] gnu: shotcut: Find ffmpeg and mlt at runtime.)

[GNU bug Tracking System]

Your message dated Sun, 26 Dec 2021 18:38:32 -0500
with message-id <Ycj8+EAwCIgtzTfJ@jasmine.lan>
and subject line Re: [bug#52247] [PATCH v2 1/2] gnu: shotcut: Find ffmpeg and 
mlt at runtime.
has caused the debbugs.gnu.org bug report #52247,
regarding [PATCH] gnu: shotcut: Find ffmpeg and mlt at runtime.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
52247: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=52247
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: shotcut: Find ffmpeg and mlt at runtime.
>
>
>
>
> Date: 
>
> Thu,  2 Dec 2021 16:18:17 +0000
>
>
>
>
> * gnu/packages/video.scm (shotcut)[arguments]<:#phases>: Symlink ffmpeg and
> mlt binaries to the Shotcut bin folder and remove unused PATH and MLT_PREFIX
> environment variables in the 'wrap-executable phase.
> ---
> fixes 50433
>
>  gnu/packages/video.scm | 17 ++++++++++++-----
>  1 file changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index eeabb11bcf..dcc2f59357 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -4918,16 +4918,23 @@ transitions, and effects and then export your film to 
> many common formats.")
>                      (frei0r (assoc-ref inputs "frei0r-plugins"))
>                      (ffmpeg (assoc-ref inputs "ffmpeg"))
>                      (jack (assoc-ref inputs "jack"))
> +                    (mlt (assoc-ref inputs "mlt"))
>                      (sdl2 (assoc-ref inputs "sdl2")))
> +               ;; Shotcut looks for ffmpeg and melt executables in the shotcut
> +               ;; directory.  Symlink them to be found at runtime.
> +               (for-each (lambda (file)
> +                           (symlink (string-append ffmpeg "/bin/" file)
> +                                    (string-append out "/bin/" file)))
> +                         '("ffmpeg" "ffplay" "ffprobe"))
> +               (for-each (lambda (file)
> +                           (symlink (string-append mlt "/bin/" file)
> +                                    (string-append out "/bin/" file)))
> +                         '("melt" "melt-7"))
>                 (wrap-program (string-append out "/bin/shotcut")
> -                 `("PATH" ":" prefix
> -                   ,(list (string-append ffmpeg "/bin")))
>                   `("LD_LIBRARY_PATH" ":" prefix
>                     ,(list (string-append jack "/lib" ":" sdl2 "/lib")))
>                   `("FREI0R_PATH" ":" =
> -                   (,(string-append frei0r "/lib/frei0r-1/")))
> -                 `("MLT_PREFIX" ":" =
> -                   (,(assoc-ref inputs "mlt"))))))))))
> +                   (,(string-append frei0r "/lib/frei0r-1/"))))))))))
>      (native-inputs
>       `(("pkg-config" ,pkg-config)
>         ("python" ,python-wrapper)
>
> base-commit: fab80c36720bbdb85730708d0dc5fceabcc22a6e
> -- 
> 2.30.2
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#52247] [PATCH v2 1/2] gnu: shotcut: Find ffmpeg and mlt at runtime.
>
>
>
>
> Date: 
>
> Sun, 26 Dec 2021 18:38:32 -0500
>
>
>
>
> On Sat, Dec 18, 2021 at 06:12:26PM +0000, Vinicius Monego wrote:
> > * gnu/packages/video.scm (shotcut)[arguments]<:#phases>: Add phase
> > 'patch-executable-paths to use full store paths for ffmpeg and mlt.
>
> Thanks! Pushed as 4e9895b462a004ac69ee92f544fe39b6c42d8525
>
>
> --- End Message ---