bug#50664: closed ([PATCH core-updates-frozen] gnu: curl: Respect #:tests?.)

[GNU bug Tracking System]

Your message dated Fri, 12 Nov 2021 00:52:43 -0500
with message-id <87tughq5sk.fsf_-_@gmail.com>
and subject line Re: bug#50664: [PATCH core-updates-frozen] gnu: curl: Respect 
#:tests?.
has caused the debbugs.gnu.org bug report #50664,
regarding [PATCH core-updates-frozen] gnu: curl: Respect #:tests?.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
50664: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=50664
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH core-updates-frozen] gnu: curl: Respect #:tests?.
>
>
>
>
> Date: 
>
> Sat, 18 Sep 2021 10:14:34 -0700
>
>
>
>
> * gnu/packages/curl.scm (curl)[arguments]<#:phases>{check}: Respect #:tests?.
> ---
>  gnu/packages/curl.scm | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/gnu/packages/curl.scm b/gnu/packages/curl.scm
> index 063a919700..17aed51fdd 100644
> --- a/gnu/packages/curl.scm
> +++ b/gnu/packages/curl.scm
> @@ -124,16 +124,16 @@
>               (rename-file (string-append out "/share/man/man3")
>                            (string-append doc "/share/man/man3"))
>               #t)))
> -        (replace
> -         'check
> -         (lambda _
> -           (substitute* "tests/runtests.pl"
> -             (("/bin/sh") (which "sh")))
> +        (replace 'check
> +          (lambda* (#:key (tests? (not target)) #:allow-other-keys)
> +            (substitute* "tests/runtests.pl"
> +              (("/bin/sh") (which "sh")))
>  
> -           ;; The top-level "make check" does "make -C tests quiet-test", which
> -           ;; is too quiet.  Use the "test" target instead, which is more
> -           ;; verbose.
> -           (invoke "make" "-C" "tests" "test"))))))
> +            (when tests?
> +              ;; The top-level "make check" does "make -C tests quiet-test", 
> which
> +              ;; is too quiet.  Use the "test" target instead, which is more
> +              ;; verbose.
> +              (invoke "make" "-C" "tests" "test")))))))
>     (synopsis "Command line tool for transferring data with URL syntax")
>     (description
>      "curl is a command line tool for transferring data with URL syntax,
>
> base-commit: 8613652f3f80105f35db13d6d9308257bbff8474
> -- 
> 2.33.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#50664: [PATCH core-updates-frozen] gnu: curl: Respect #:tests?.
>
>
>
>
> Date: 
>
> Fri, 12 Nov 2021 00:52:43 -0500
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
>
>
>
>
> Hello,
>
> Sarah Morgensen <iskarian@mgsn.dev> writes:
>
> > * gnu/packages/curl.scm (curl)[arguments]<#:phases>{check}: Respect #:tests?.
> > ---
> > Changes from v1:
> >
> > * Do not provide a default value for tests?, since gnu-build-system provides
> >   one.
> >
> > --
> > Sarah
> >  gnu/packages/curl.scm | 18 +++++++++---------
> >  1 file changed, 9 insertions(+), 9 deletions(-)
> >
> > diff --git a/gnu/packages/curl.scm b/gnu/packages/curl.scm
> > index 063a919700..4c90c7b301 100644
> > --- a/gnu/packages/curl.scm
> > +++ b/gnu/packages/curl.scm
> > @@ -124,16 +124,16 @@
> >               (rename-file (string-append out "/share/man/man3")
> >                            (string-append doc "/share/man/man3"))
> >               #t)))
> > -        (replace
> > -         'check
> > -         (lambda _
> > -           (substitute* "tests/runtests.pl"
> > -             (("/bin/sh") (which "sh")))
> > +        (replace 'check
> > +          (lambda* (#:key tests? #:allow-other-keys)
> > +            (substitute* "tests/runtests.pl"
> > +              (("/bin/sh") (which "sh")))
> >  
> > -           ;; The top-level "make check" does "make -C tests quiet-test", 
> > which
> > -           ;; is too quiet.  Use the "test" target instead, which is more
> > -           ;; verbose.
> > -           (invoke "make" "-C" "tests" "test"))))))
> > +            (when tests?
> > +              ;; The top-level "make check" does "make -C tests quiet-test", 
> > which
> > +              ;; is too quiet.  Use the "test" target instead, which is more
> > +              ;; verbose.
> > +              (invoke "make" "-C" "tests" "test")))))))
> >     (synopsis "Command line tool for transferring data with URL syntax")
> >     (description
> >      "curl is a command line tool for transferring data with URL syntax,
> >
> > base-commit: 8613652f3f80105f35db13d6d9308257bbff8474
>
> This got merged in core-updates-frozen as
> 460d6aca0c9a8f8443d50e5a5cf2bf9841bcc559; and I just noticed I had
> forgotten to put my signed-off-by line; apologies.
>
> Thank you!
>
> Closing.
>
> Maxim
>
>
> --- End Message ---