--- Begin Message ---
|
Subject: |
OS X, one failure: tests/tail-2/pipe-f.sh |
|
Date: |
Mon, 20 Sep 2021 21:34:11 -0700 |
Uname -v reports this:
Darwin Kernel Version 20.6.0: Mon Aug 30 06:12:21 PDT 2021;
root:xnu-7195.141.6~3/RELEASE_X86_64
Sorry, I don't have time to delve into this, but here's the log from
the sole test failure:
pipe-f.log
Description: Binary data
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#50714: OS X, one failure: tests/tail-2/pipe-f.sh |
|
Date: |
Tue, 21 Sep 2021 17:53:39 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:84.0) Gecko/20100101 Thunderbird/84.0 |
On 21/09/2021 16:50, Paul Eggert wrote:
On 9/21/21 6:08 AM, Pádraig Brady wrote:
The attached fixes this on my testing on macOS.
Thanks fixing this portability bug that I introduced. I also suggest
changing this:
#ifdef _AIX
- /* select on AIX was seen to give a readable event immediately. */
+ /* select on AIX was seen to give a readable event immediately.
+ Note poll doesn't work for this application on macOS. */
to something like this:
-#ifdef _AIX
- /* select on AIX was seen to give a readable event immediately. */
+ /* Use 'poll' on AIX (where 'select' was seen to give a readable
+ event immediately) or if using inotify (which relies on 'poll'
+ anyway). Otherwise, use 'select' as it's more portable;
+ 'poll' doesn't work for this application on macOS. */
+#if defined _AIX || HAVE_INOTIFY
so that if the inotify code uses 'poll' it uses 'poll' uniformly rather
than sometimes 'poll' and sometimes 'select'.
Done, and pushed.
thanks for the review/improvement.
cheers,
Pádraig
--- End Message ---