bug#48026: closed ([PATCH] Possible typo in tramp-get-remote-gid)

[GNU bug Tracking System]

Your message dated Mon, 26 Apr 2021 10:00:50 +0200
with message-id <87pmyhlbkd.fsf@gmx.de>
and subject line Re: bug#48026: [PATCH] Possible typo in tramp-get-remote-gid
has caused the debbugs.gnu.org bug report #48026,
regarding [PATCH] Possible typo in tramp-get-remote-gid
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
48026: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=48026
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] Possible typo in tramp-get-remote-gid
>
>
>
>
> Date: 
>
> Mon, 26 Apr 2021 09:10:27 +0200
>
>
>
>
> Hi,
>
> I was browsing through TRAMP's source code and noticed a possible typo
> in tramp-get-remote-gid.  Please note that I have almost no familiarity
> with the code, so it may well not even be a typo.
>
> Here is what I am talking about:
>
> >From 87ed8e1e19fd4ddb0922d907a45569c61598369d Mon Sep 17 00:00:00 2001
> From: Dario Gjorgjevski <dario.gjorgjevski+git@gmail.com>
> Date: Mon, 26 Apr 2021 09:01:51 +0200
> Subject: [PATCH] Fix typo in tramp-get-remote-gid
>
> * lisp/net/tramp.el (tramp-get-remote-gid): Pass the correct operation
> to find-file-name-handler.
> ---
>  lisp/net/tramp.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/net/tramp.el b/lisp/net/tramp.el
> index a411aaf..dc34b8f 100644
> --- a/lisp/net/tramp.el
> +++ b/lisp/net/tramp.el
> @@ -5080,7 +5080,7 @@ ID-FORMAT valid values are `string' and `integer'."
>      (or (when-let
>             ((handler
>               (find-file-name-handler
> -              (tramp-make-tramp-file-name vec) 'tramp-get-remote-uid)))
> +              (tramp-make-tramp-file-name vec) 'tramp-get-remote-gid)))
>           (funcall handler #'tramp-get-remote-gid vec id-format))
>         ;; Ensure there is a valid result.
>         (and (equal id-format 'integer) tramp-unknown-id-integer)
> -- 
> 2.31.GIT
>
> Best regards,
> Dario
>
> -- 
> $ keyserver=hkps://hkps.pool.sks-keyservers.net
> $ keyid=744A4F0B4F1C9371
> $ gpg --keyserver $keyserver --search-keys $keyid
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#48026: [PATCH] Possible typo in tramp-get-remote-gid
>
>
>
>
> Date: 
>
> Mon, 26 Apr 2021 10:00:50 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
>
>
>
>
> Version: 28.1
>
> Dario Gjorgjevski <dario.gjorgjevski@gmail.com> writes:
>
> > Hi,
>
> Hi Dario,
>
> > I was browsing through TRAMP's source code and noticed a possible typo
> > in tramp-get-remote-gid.  Please note that I have almost no familiarity
> > with the code, so it may well not even be a typo.
>
> It is a typo, indeed. Thanks for reporting!
>
> I've pushed your patch to master, closing the bug.
>
> > Best regards,
> > Dario
>
> Best regards, Michael.
>
>
> --- End Message ---