bug#47377: closed ([PATCH] Fix preeditarea reporting wrong spot)

[GNU bug Tracking System]

Your message dated Thu, 25 Mar 2021 17:26:00 +0200
with message-id <83tuozqmpj.fsf@gnu.org>
and subject line Re: bug#47377: [PATCH] Fix preeditarea reporting wrong spot
has caused the debbugs.gnu.org bug report #47377,
regarding [PATCH] Fix preeditarea reporting wrong spot
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
47377: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=47377
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] Fix preeditarea reporting wrong spot
>
>
>
>
> Date: 
>
> Thu, 25 Mar 2021 14:57:13 +0800
>
>
>
>
> User-agent: 
>
> mu4e 1.4.10; emacs 28.0.50
>
>
>
>
>
> This patch adjust the x position of preeditarea with both left 
> fringe
> and left margin, which prevents IME preedit box (such as fcitx) 
> from
> placing at the wrong position in GUI emacs.
>
> This fixes the bug described in 
> https://lists.defectivebydesign.org/archive/html/emacs-devel/2017-02/msg00817.html
>
> I've already assigned the form for contributing to emacs.
>
> regards,
> Amos
>
> >From 769adf8858c067e779c07087f53048455ff1c7f3 Mon Sep 17 00:00:00 2001
> From: Amos Bird <amosbird@gmail.com>
> Date: Thu, 25 Mar 2021 14:50:46 +0800
> Subject: [PATCH] Fix preeditarea reporting wrong spot.
>
> This patch adjust the x position of preeditarea with both left fringe
> and left margin, which prevents IME preedit box (such as fcitx) from
> placing at the wrong position in GUI emacs.
> ---
>  src/xfns.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/xfns.c b/src/xfns.c
> index d90644819b..0507dc8f61 100644
> --- a/src/xfns.c
> +++ b/src/xfns.c
> @@ -2783,7 +2783,7 @@ xic_set_preeditarea (struct window *w, int x, int y)
>    XVaNestedList attr;
>    XPoint spot;
>  
> -  spot.x = WINDOW_TO_FRAME_PIXEL_X (w, x) + WINDOW_LEFT_FRINGE_WIDTH (w);
> +  spot.x = WINDOW_TO_FRAME_PIXEL_X (w, x) + WINDOW_LEFT_FRINGE_WIDTH (w) + 
> WINDOW_LEFT_MARGIN_WIDTH(w);
>    spot.y = WINDOW_TO_FRAME_PIXEL_Y (w, y) + FONT_BASE (FRAME_FONT (f));
>    attr = XVaCreateNestedList (0, XNSpotLocation, &spot, NULL);
>    XSetICValues (FRAME_XIC (f), XNPreeditAttributes, attr, NULL);
> -- 
> 2.31.0
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#47377: [PATCH] Fix preeditarea reporting wrong spot
>
>
>
>
> Date: 
>
> Thu, 25 Mar 2021 17:26:00 +0200
>
>
>
>
> > From: Amos Bird <amosbird@gmail.com>
> > Date: Thu, 25 Mar 2021 14:57:13 +0800
> > 
> > This patch adjust the x position of preeditarea with both left 
> > fringe
> > and left margin, which prevents IME preedit box (such as fcitx) 
> > from
> > placing at the wrong position in GUI emacs.
> > 
> > This fixes the bug described in 
> > https://lists.defectivebydesign.org/archive/html/emacs-devel/2017-02/msg00817.html
> > 
> > I've already assigned the form for contributing to emacs.
>
> Thanks, installed.
>
>
> --- End Message ---