emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#46429: closed ([PATCH 0/1] guix time-machine: fail when unrecognized


From: GNU bug Tracking System
Subject: bug#46429: closed ([PATCH 0/1] guix time-machine: fail when unrecognized option)
Date: Thu, 11 Mar 2021 22:26:02 +0000

Your message dated Thu, 11 Mar 2021 23:25:41 +0100
with message-id <875z1xwcnu.fsf_-_@gnu.org>
and subject line Re: bug#46429: [PATCH 0/1] guix time-machine: fail when 
unrecognized option
has caused the debbugs.gnu.org bug report #46429,
regarding [PATCH 0/1] guix time-machine: fail when unrecognized option
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
46429: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=46429
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [PATCH 0/1] guix time-machine: fail when unrecognized option Date: Wed, 10 Feb 2021 22:38:50 +0100
Hi,

Currently, the command line:

--8<---------------cut here---------------start------------->8---
$ guix time-machine kikoo -- --version
guix (GNU Guix) 8f8a1485b80de707caecf6e7e29b520cd8cf611e
Copyright © 2021 les auteurs de Guix
Licence GPLv3+ : GNU GPL version 3 ou ultérieure 
<http://www.gnu.org/licenses/gpl.fr.html>
Ceci est un logiciel libre : vous êtes libre de le modifier et de le 
redistribuer.
Il n'y a AUCUNE GARANTIE, dans les limites permises par la loi.
--8<---------------cut here---------------end--------------->8---

does not fail but uses the current commit.  This leads to confusing behaviour
as described in <http://issues.guix.gnu.org/46336>, for instance:

$ guix time-machine 8e7e414aa998fe8c0de8a491c91aab8b8d9c58f4 -- graph maven

which had failed with:

--8<---------------cut here---------------start------------->8---
"453f18db343cbad1892186b85c7eb07f364b399e"; system: "x86_64-linux";
host version: "838347207cdd96de1ad0127aaf4b2c378c7c2148"; pull-version: 1).
--8<---------------cut here---------------end--------------->8---

The failure is another reason.  However the backtrace is not informative about
the real issue which is a misuse of the command line.


This trivial patch fixes it by gracefully failing.


All the best,
simon



zimoun (1):
  scripts: time-machine: Fail when unrecognized option.

 guix/scripts/time-machine.scm | 3 +++
 1 file changed, 3 insertions(+)


base-commit: 8f8a1485b80de707caecf6e7e29b520cd8cf611e
-- 
2.29.2




--- End Message ---
--- Begin Message --- Subject: Re: bug#46429: [PATCH 0/1] guix time-machine: fail when unrecognized option Date: Thu, 11 Mar 2021 23:25:41 +0100 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
Hi!

zimoun <zimon.toutoune@gmail.com> skribis:

> * guix/scripts/time-machine (parse-args): Fail when unrecognized option.

I tweaked the error message to be consistent with the other commands and
pushed as f1c4df15c31a81cca03a748a21ec38774e8114c0.

Thanks,
Ludo’.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]