bug#46953: closed ([PATCH] gnu: Add xzgv.)

[GNU bug Tracking System]

Your message dated Mon, 08 Mar 2021 00:08:28 +0100
with message-id <875z225zpv.fsf@nicolasgoaziou.fr>
and subject line Re: [bug#46953] [PATCH] gnu: Add xzgv.
has caused the debbugs.gnu.org bug report #46953,
regarding [PATCH] gnu: Add xzgv.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
46953: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=46953
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: Add xzgv.
>
>
>
>
> Date: 
>
> Fri,  5 Mar 2021 22:46:42 +0100
>
>
>
>
> * gnu/packages/image-viewers.scm (xzgv): New variable.
> ---
>  gnu/packages/image-viewers.scm | 38 ++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
>
> diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
> index bddf86568c..8fa6743020 100644
> --- a/gnu/packages/image-viewers.scm
> +++ b/gnu/packages/image-viewers.scm
> @@ -17,6 +17,7 @@
>  ;;; Copyright © 2020 Pierre Neidhardt <mail@ambrevar.xyz>
>  ;;; Copyright © 2021 Rovanion Luckey <rovanion.luckey@gmail.com>
>  ;;; Copyright © 2021 Xinglu Chen <public@yoctocell.xyz>
> +;;; Copyright © 2021 Stefan Reichör <stefan@xsteve.at>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -748,3 +749,40 @@ allows creating false color images.  A unique feature of 
> Nomacs is the
>  synchronization of multiple instances.")
>      (home-page "https://nomacs.org/";)
>      (license license:gpl3+)))
> +
> +(define-public xzgv
> +  (package
> +    (name "xzgv")
> +    (version "0.9.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://sourceforge/xzgv/"
> +                                  version "/" name "-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "17l1xr9v07ggwga3vn0z1i4lnwjrr20rr8z1kjbw71aaijxl18i5"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'override-target-directory
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (substitute* "config.mk"
> +               (("/usr/local") (assoc-ref outputs "out")))))
> +         (delete 'configure)                     ; no configure script
> +         (replace 'install
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (bin (string-append out "/bin")))
> +               (install-file "src/xzgv" bin))))) ; just install the executable
> +       #:tests? #f))                             ; no rule for target 'test'
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("gtk+" ,gtk+-2)
> +       ("libexif" ,libexif)))
> +    (synopsis "Picture viewer for X with a thumbnail-based selector")
> +    (description
> +     "xzgv is a fast image viewer that provides extensive keyboard support.")
> +    (home-page "https://sourceforge.net/projects/xzgv/";)
> +    (license license:gpl2+)))
> -- 
> 2.25.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#46953] [PATCH] gnu: Add xzgv.
>
>
>
>
> Date: 
>
> Mon, 08 Mar 2021 00:08:28 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
>
>
>
>
> Hello,
>
> Stefan Reichör <stefan@xsteve.at> writes:
>
> > * gnu/packages/image-viewers.scm (xzgv): New variable.
>
> Applied. Thank you.
>
> > +    (source (origin
> > +              (method url-fetch)
> > +              (uri (string-append "mirror://sourceforge/xzgv/"
> > +                                  version "/" name "-" version ".tar.gz"))
>
> Nitpick: we usually hard-code name here. So did I.
>
> Regards,
> -- 
> Nicolas Goaziou
>
>
> --- End Message ---