--- Begin Message ---
Subject: |
Fwd: [PATCH] Make assert-valid-graph public |
Date: |
Thu, 18 Feb 2021 21:19:54 +0300 |
I would like to reuse assert-valid-graph function for home-shepherd-service
for `guix home` I'm currently implementing. It seems reasonable to make this
function public instead of copying or reimplementing it.
--
Best regards,
Andrew Tropin
0001-gnu-services-shepherd-Make-assert-valid-graph-public.patch
Description: Source code patch
--- End Message ---
--- Begin Message ---
Subject: |
Re: bug#46619: [PATCH] Make assert-valid-graph public |
Date: |
Wed, 03 Mar 2021 14:22:32 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hi Andrew,
Andrew Tropin <andrew@trop.in> skribis:
> From ffc244f5845996bf4b0365024ac866c86cef81df Mon Sep 17 00:00:00 2001
> From: Andrew Tropin <andrew@trop.in>
> Date: Thu, 18 Feb 2021 13:30:22 +0300
> Subject: [PATCH] gnu: services: shepherd: Make assert-valid-graph public
>
> ---
> gnu/services/shepherd.scm | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
I added a commit log and pushed as
63bee8f0addc95c81426199c9fbf1d0bcf7f1450.
As mentioned on IRC, note that this kind of procedure doesn’t make for a
great API, which is why it’s usually kept private. Second, if a
procedure like this one doesn’t have any user in Guix proper, it could
well be removed or changed incompatibly, so beware.
In this case, I think it’s acceptable to make it public though.
Thanks and apologies for the delay!
Ludo’.
--- End Message ---