bug#44495: closed ([PATCH] gnu: Add emacs-monokai-theme.)

[GNU bug Tracking System]

Your message dated Sat, 07 Nov 2020 10:47:35 +0100
with message-id <87blg9jy6g.fsf@nicolasgoaziou.fr>
and subject line Re: [bug#44495] [PATCH] gnu: Add emacs-monokai-theme.
has caused the debbugs.gnu.org bug report #44495,
regarding [PATCH] gnu: Add emacs-monokai-theme.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
44495: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=44495
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: Add emacs-monokai-theme.
>
>
>
>
> Date: 
>
> Fri, 6 Nov 2020 16:39:04 -0700
>
>
>
>
> >From 5565ff611ba239b82141d0055bd71042be56419b Mon Sep 17 00:00:00 2001
> From: Noah Landis <noahlandis@posteo.net>
> Date: Fri, 6 Nov 2020 16:37:12 -0700
> Subject: [PATCH] gnu: Add emacs-monokai-theme.
>
> ---
>  gnu/packages/emacs-xyz.scm | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 47657c9ca0..3e231a93d1 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -25331,3 +25331,24 @@ service.")
>  uncluttered design pattern to achieve optimal focus and readability for code
>  syntax highlighting and UI components.")
>      (license license:expat)))
> +
> +(define-public emacs-monokai-theme
> +  (package
> +    (name "emacs-monokai-theme")
> +    (version "3.5.3")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/oneKelvinSmith/monokai-emacs";)
> +             (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "0dy8c3349j7fmp8052hbgvk0b7ldlv5jqpg0paq1i0hlypivd30i"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://github.com/oneKelvinSmith/monokai-emacs";)
> +    (synopsis "High contrast color theme for Emacs")
> +    (description
> +     "Monokai theme is a port of the popular TextMate Monokai theme for Emacs.
> +It uses built-in theming support available in Emacs 24 or later.")
> +    (license license:gpl3+)))
> -- 
> 2.29.2
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#44495] [PATCH] gnu: Add emacs-monokai-theme.
>
>
>
>
> Date: 
>
> Sat, 07 Nov 2020 10:47:35 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
>
>
>
>
> Hello,
>
> Noah Landis <noahlandis@posteo.net> writes:
>
> > Subject: [PATCH] gnu: Add emacs-monokai-theme.
>
> Thank you!
>
> I "fixed" the commit message, which should be:
>
>     gnu: Add emacs-monokai-theme.
>
>     * gnu/packages/emacs-xyz.scm (emacs-monokai-theme): New variable.
>
> If you use Yasnippets, you can simply type "update" + TAB in an empty
> commit buffer.
>
> Also I suggest to insert new packages elsewhere than at the very end of
> the "emacs-xyz.scm" file, as this location is prone to introduce merge
> conflicts.
>
> > +    (description
> > +     "Monokai theme is a port of the popular TextMate Monokai theme for 
> > Emacs.
> > +It uses built-in theming support available in Emacs 24 or later.")
>
> I removed the last sentence, which is not useful in our context (Guix
> provides Emacs 27).
>
> Patch applied.
>
> Regards,
> -- 
> Nicolas Goaziou
>
>
> --- End Message ---