bug#44275: closed ([PATCH] gnu: Add python-pydub.)

[GNU bug Tracking System]

Your message dated Fri, 30 Oct 2020 16:40:47 -0400
with message-id <20201030204047.GA10794@jasmine.lan>
and subject line Re: [PATCH v2] gnu: Add python-pydub.
has caused the debbugs.gnu.org bug report #44275,
regarding [PATCH] gnu: Add python-pydub.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
44275: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=44275
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: Add python-pydub.
>
>
>
>
> Date: 
>
> Wed, 28 Oct 2020 09:56:54 +0100
>
>
>
>
> * gnu/packages/python-xyz.scm (python-pydub): New variable.
> ---
>  gnu/packages/python-xyz.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 6c5ccac647..55580a251b 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -16659,6 +16659,28 @@ ignoring formatting changes.")
>  (define-public python2-pydiff
>    (package-with-python2 python-pydiff))
>  
> +(define-public python-pydub
> +  (package
> +    (name "python-pydub")
> +    (version "0.24.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "pydub" version))
> +       (sha256
> +        (base32
> +         "0sfwfq7yjv4bl3yqbmizszscafvwf4zr40hzbsy7rclvzyznh333"))))
> +    (build-system python-build-system)
> +    (home-page "http://pydub.com";)
> +    (propagated-inputs
> +     `(("ffmpeg" ,ffmpeg)
> +       ("python-scipy" ,python-scipy)))
> +    (synopsis "Manipulate audio with an simple and easy high level interface")
> +    (description
> +     "@code{pydub} makes it easy to manipulate audio.  It relies on
> +@code{ffmpeg} to open various audio formats.")
> +    (license license:expat))) ; MIT license
> +
>  (define-public python-tqdm
>    (package
>      (name "python-tqdm")
> -- 
> 2.29.1
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [PATCH v2] gnu: Add python-pydub. Date: Fri, 30 Oct 2020 16:40:47 -0400

On Thu, Oct 29, 2020 at 10:09:29AM +0100, Tanguy Le Carrour wrote:
> * gnu/packages/python-xyz.scm (python-pydub): New variable.

Thanks! Pushed as 96767739a1d2222ed802dd5dcfa2bda1df85df77

> +         (add-after 'unpack 'fix-ffmpeg-path
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (let ((ffmpeg (assoc-ref inputs "ffmpeg")))
> +               (substitute* '("pydub/utils.py")
> +                 (("return \"ffmpeg\"")
> +                  (string-append "return \"" ffmpeg "/bin/ffmpeg\""))
> +                 (("return \"ffplay\"")
> +                  (string-append "return \"" ffmpeg "/bin/ffplay\""))
> +                 (("return \"ffprobe\"")
> +                  (string-append "return \"" ffmpeg "/bin/ffprobe\""))
> +                 (("warn\\(\"Couldn't find ff") "# warn\\(\"Couldn't find 
> ff"))
> +               #t))))))

This solution is more correct than the one I suggested. Thanks!

> +    (home-page "http://pydub.com";)

I made this use HTTPS.

> +    (synopsis "Manipulate audio with an simple and easy high level 
> interface")
> +    (description
> +     "@code{pydub} makes it easy to manipulate audio.  It relies on
> +@code{ffmpeg} to open various audio formats.")

And I tweaked these to avoid so-called "marketing language" and to
clarify that pydub is in Python, which I think can be useful when
searching for packages.

signature.asc
Description: PGP signature

--- End Message ---