bug#44169: closed ([PATCH 0/3] Referring to swap with UUIDs and labels)

[GNU bug Tracking System]

Your message dated Fri, 30 Oct 2020 01:17:06 +0100
with message-id <87pn50y3ct.fsf@gnu.org>
and subject line Re: [bug#44169] [PATCH 3/3] installer: Use UUIDs in the 
'swap-devices' field.
has caused the debbugs.gnu.org bug report #44169,
regarding [PATCH 0/3] Referring to swap with UUIDs and labels
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
44169: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=44169
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/3] Referring to swap with UUIDs and labels
>
>
>
>
> Date: 
>
> Fri, 23 Oct 2020 11:58:22 +0200
>
>
>
>
> Hi!
>
> Someone reported on IRC yesterday that the installer generates
> ‘swap-devices’ that explicitly list /dev nodes.
>
> These patches change that so that it uses UUIDs instead.  It’s
> only in the unencrypted case anyway, because I think we don’t
> create swap partitions in the full-encrypted mode because the
> partition would be unencrypted (or we’d need to set up another
> LUKS mapping, but the installer doesn’t do that).
>
> The ‘swap’ Shepherd service can now look up swap devices by
> UUID/label.  Note that it uses the generic ‘find-partition-by-label’
> and ‘find-partition-by-uuid’ procedures, which means it could
> stumble upon a partition that’s not a swap partition.  That’s
> unlikely and probably OK though: the worst that can happen is
> that the ‘swap’ Shepherd service will fail to start.
>
> Feedback welcome!
>
> Ludo’.
>
> Ludovic Courtès (3):
>   file-systems: Allow swap space lookup by UUID/label.
>   services: swap: Allow for UUIDs and file system labels.
>   installer: Use UUIDs in the 'swap-devices' field.
>
>  doc/guix.texi              | 34 +++++++++++++++++++----
>  gnu/build/file-systems.scm | 43 ++++++++++++++++++++++++++++-
>  gnu/installer/parted.scm   |  7 ++++-
>  gnu/services/base.scm      | 55 +++++++++++++++++++++++++++++---------
>  4 files changed, 120 insertions(+), 19 deletions(-)
>
> -- 
> 2.28.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#44169] [PATCH 3/3] installer: Use UUIDs in the 'swap-devices' field.
>
>
>
>
> Date: 
>
> Fri, 30 Oct 2020 01:17:06 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
>
>
>
>
> Hi,
>
> Ludovic Courtès <ludo@gnu.org> skribis:
>
> > I unleashed my creativity, leading to the v2 I just sent.  The trick is
> > to add an explicit request/reply sequence with clients right before the
> > config file is generated.
> >
> > I also added the comments regarding PAGE_SIZE as you suggested.
> >
> > I think it’s probably OK for 1.2, though another round of testing for
> > the ISO would be welcome.
>
> I went ahead and pushed it as 1c6d98533153bc8e0e36236e7fbcf1eb5e178d26.
>
> I’ll update the ‘guix’ package as a followup.
>
> Thanks,
> Ludo’.
>
>
> --- End Message ---