emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#44190: closed ([PATCH] gnu: Add mpdris2)


From: GNU bug Tracking System
Subject: bug#44190: closed ([PATCH] gnu: Add mpdris2)
Date: Sun, 25 Oct 2020 19:07:01 +0000

Your message dated Sun, 25 Oct 2020 15:06:24 -0400
with message-id <20201025190624.GA29289@jasmine.lan>
and subject line Re: [bug#44190] [PATCH] gnu: Add mpdris2
has caused the debbugs.gnu.org bug report #44190,
regarding [PATCH] gnu: Add mpdris2
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
44190: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=44190
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [PATCH] gnu: Add mpdris2 Date: Sat, 24 Oct 2020 13:24:05 +0200
* gnu/packages/mpd.scm (mpdris2): New package.
---
 gnu/packages/mpd.scm | 48 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)

diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm
index 6be7c930a1..323ae51af7 100644
--- a/gnu/packages/mpd.scm
+++ b/gnu/packages/mpd.scm
@@ -8,6 +8,7 @@
 ;;; Copyright © 2018, 2019, 2020 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2019 Evan Straw <evan.straw99@gmail.com>
 ;;; Copyright © 2020 Ricardo Wurmus <rekado@elephly.net>
+;;; Copyright © 2020 Lars-Dominik Braun <lars@6xq.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -34,7 +35,9 @@
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system meson)
   #:use-module (guix build-system python)
+  #:use-module (gnu packages autotools)
   #:use-module (gnu packages avahi)
+  #:use-module (gnu packages base)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages gettext)
   #:use-module (gnu packages gnome)
@@ -53,6 +56,7 @@
   #:use-module (gnu packages pcre)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)
+  #:use-module (gnu packages python-xyz)
   #:use-module (gnu packages pulseaudio)
   #:use-module (gnu packages sphinx)
   #:use-module (gnu packages sqlite)
@@ -369,3 +373,47 @@ MPD library in a similar way to many other music players' 
'shuffle library'
 feature. ashuffle works like any other MPD client, and can be used alongside
 other MPD frontends.")
     (license license:expat)))
+
+(define-public mpdris2
+  (package
+    (name "mpdris2")
+    (version "0.8")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/eonpatapon/mpDris2.git";)
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "048b8acsd1b8kcxzd9fsh5p9g2an9c4rznicfcpyrsjz5syv894h"))))
+    (build-system gnu-build-system)
+    ;; Manually wrap the binary, because we’re not using python-build-system.
+    (arguments
+     '(#:phases
+       (modify-phases %standard-phases
+         (add-after 'install 'wrap-program
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (let ((out         (assoc-ref outputs "out"))
+                   (python-path (getenv "PYTHONPATH")))
+               (wrap-program (string-append out "/bin/mpDris2")
+                 `("PYTHONPATH" ":" prefix (,python-path)))
+               #t))))))
+    (inputs
+     `(("python-mpd2" ,python-mpd2)
+       ("python-dbus" ,python-dbus)
+       ("python-pygobject" ,python-pygobject)
+       ("python" ,python)))             ; Sets PYTHONPATH.
+    ;; For bootstrapping.
+    (native-inputs
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)
+       ("gettext" ,gnu-gettext)
+       ("which" ,which)
+       ("intltool" ,intltool)))
+    (synopsis "MPRIS V2.1 support for mpd")
+    (description "Client for the Music Player Daemon providing MPRIS 2
+support")
+    (home-page "https://github.com/eonpatapon/mpDris2";)
+    (license license:gpl3)))
+
-- 
2.26.2




--- End Message ---
--- Begin Message --- Subject: Re: [bug#44190] [PATCH] gnu: Add mpdris2 Date: Sun, 25 Oct 2020 15:06:24 -0400
On Sat, Oct 24, 2020 at 01:24:05PM +0200, Lars-Dominik Braun wrote:
> * gnu/packages/mpd.scm (mpdris2): New package.

Thanks! Pushed as 349666b7d233b551781d37eb1fed2c1125610097 with the
following minor changes:

> +                    (url "https://github.com/eonpatapon/mpDris2.git";)

I changed this to the URL reported as a permanent redirection by `guix
lint` — concretely, I removed the ".git" part.

> +    (synopsis "MPRIS V2.1 support for mpd")

I wrote it as "MPD", which is how it's stylized upstream:

https://www.musicpd.org/

> +    (license license:gpl3)))

I changed this to gpl3+, since the license header of the main source
file includes the "any later version" string.

Attachment: signature.asc
Description: PGP signature


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]