--- Begin Message ---
|
Subject: |
`make authenticate` fails to find the keyring branch |
|
Date: |
Mon, 8 Jun 2020 14:54:04 -0400 |
I just tried pushing for the first time since installing the new
pre-push hook that runs `make authenticate`.
This failed with the following error:
Git error: cannot locate remote-tracking branch 'keyring'
However, `git branch --all` includes "remotes/origin/keyring".
After I did `git checkout origin/keyring`, it worked.
Let's update the manual section Commit Access with the recommended way
to make this branch accessible to `make authenticate`. Maybe it should
even do it automatically?
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#41764: `make authenticate` fails to find the keyring branch |
|
Date: |
Sat, 24 Oct 2020 17:41:44 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hi Ludo,
Thanks for the quick revision.
Ludovic Courtès <ludo@gnu.org> writes:
>> # Authenticate the current Git checkout by checking signatures on every
>> commit.
>> +GUIX_GIT_KEYRING = origin/keyring
>
> You need “?=” or users won’t be able to override it.
The macro definitions provided through the command line are equivalent
to adding these definitions to the end of the file, so this wouldn't
make any difference, so I leave it as only =.
>
> s/git/Git/ in the paragraph, but otherwise LGTM! ‘origin/keyring’ is
> certainly a better default than ‘keyring’.
Pushed with this change as ef6596a20c to master.
Happy hacking!
Miguel
signature.asc
Description: PGP signature
--- End Message ---