--- Begin Message ---
|
Subject: |
gnu: python-shapely fails to build |
|
Date: |
Wed, 07 Oct 2020 23:32:01 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hi,
python-shapely fails to build, because it can't find the c libary,
the package definition was not complete (patch at the end).
Now the package finds a C libary but the Test Suite fails with the
follwoing error:
--8<---------------cut here---------------start------------->8---
======================================================================
FAIL: test_operations (tests.test_operations.OperationsTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/tmp/guix-build-python-shapely-1.6.4.post2.drv-0/Shapely-1.6.4.post2/tests/test_operations.py",
line 25, in test_operations
self.assertIsInstance(point.intersection(Point(-1, -1)),
AssertionError: <shapely.geometry.point.Point object at 0x7fffe1544f70> is not
an instance of <class 'shapely.geometry.collection.GeometryCollection'>
--8<---------------cut here---------------end--------------->8---
This package was last successfully built on 13th September.
Malte
--8<---------------cut here---------------start------------->8---
diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 459526941b..02744bfc6d 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -533,13 +533,16 @@ pidof, tty, taskset, pmap.")
(let ((geos (assoc-ref inputs "geos"))
(glibc (assoc-ref inputs ,(if (%current-target-system)
"cross-libc" "libc"))))
- (substitute* "shapely/geos.py"
- (("_lgeos = load_dll\\('geos_c', fallbacks=.*\\)")
- (string-append "_lgeos = load_dll('geos_c', fallbacks=['"
- geos "/lib/libgeos_c.so'])"))
- (("free = load_dll\\('c'\\)\\.free")
- (string-append "free = load_dll('c', fallbacks=['"
- glibc "/lib/libc.so.6']).free"))))
+ (map
+ (lambda (file)
+ (substitute* file
+ (("_lgeos = load_dll\\('geos_c', fallbacks=.*\\)")
+ (string-append "_lgeos = load_dll('geos_c', fallbacks=['"
+ geos "/lib/libgeos_c.so'])"))
+ (("free = load_dll\\('c'\\)\\.free")
+ (string-append "free = load_dll('c', fallbacks=['"
+ glibc "/lib/libc.so.6']).free"))))
+ '("shapely/geos.py" "shapely/_buildcfg.py")))
#t)))))
(home-page "https://github.com/Toblerity/Shapely";)
(synopsis "Library for the manipulation and analysis of geometric objects")
--8<---------------cut here---------------end--------------->8---
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#43855: [PATCH] gnu: python-shapely: Update to 1.7.1. |
|
Date: |
Fri, 9 Oct 2020 08:01:27 +0300 |
On Thu, Oct 08, 2020 at 08:25:50PM +0200, Malte Frank Gerdes wrote:
> It seems python-shapely assumes musl libc, because the store path of
> glibc was missing in one place. Now the Test suite runs without failure.
>
> Malte
>
Looks good! Certainly a smaller patch than I was expecting.
I added a copyright line for you and pushed the patch.
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
signature.asc
Description: PGP signature
--- End Message ---