bug#43090: closed (emacs-clojure-mode 5.12.0 build failure)

[GNU bug Tracking System]

Your message dated Sat, 29 Aug 2020 23:07:37 +0300
with message-id <87ft85nrli.fsf@gmail.com>
and subject line Re: bug#43090: [PATCH] emacs-clojure-mode 5.12.0 build failure
has caused the debbugs.gnu.org bug report #43090,
regarding emacs-clojure-mode 5.12.0 build failure
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
43090: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=43090
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: emacs-clojure-mode 5.12.0 build failure Date: Fri, 28 Aug 2020 19:53:27 +0200

Hello,

I'm on latest master:

--8<---------------cut here---------------start------------->8---

Generation 10   Aug 28 2020 18:19:10    (current)
    guix 95eade1
    repository URL: https://git.savannah.gnu.org/git/guix.git
    branch: master
    commit: 95eade1389beaad79f6d07c7ffeff4235424eab0

--8<---------------cut here---------------end--------------->8---

guix build `emacs-clojure-mode` fails with this error:

--8<---------------cut here---------------start------------->8---

starting phase `check'
Loading 
/gnu/store/8w81gl56lxaylbyslzz3z32k6fxacl66-emacs-buttercup-1.23/share/emacs/site-lisp/buttercup-autoloads...
Loading 
/gnu/store/rc5in960n20xsb21dr3ri71mx1vswqd9-emacs-dash-2.17.0/share/emacs/site-lisp/dash-autoloads...
Loading 
/gnu/store/hfmbkal5jfnz0zix4iw8f2wf6zmnr39h-emacs-paredit-24/share/emacs/site-lisp/paredit-autoloads...
Loading 
/gnu/store/cc556b4zrqkgk8yhy9f4b354w0pqdm4p-emacs-s-1.12.0/share/emacs/site-lisp/s-autoloads...
Running tests on Emacs 27.1
Loading /tmp/guix-build-emacs-clojure-mode-5.12.0.drv-0/source/clojure-mode.el 
(source)...
Warning (emacs): 
clojure-mode.el:1761: All variables and subroutines might as well have a 
documentation string
Failing due to checkdoc warnings...
command "buttercup" failed with status 1

--8<---------------cut here---------------end--------------->8---

It's an upstream issue and Jack Hill reported this issue 23 days ago
https://github.com/clojure-emacs/clojure-mode/issues/568.

It was emacs-clojure-mode-5.11.0, different line but same code:

--8<---------------cut here---------------start------------->8---

;; project.el integration
(cl-defmethod project-roots ((project (head clojure)))
  (list (cdr project)))

--8<---------------cut here---------------end--------------->8---

I'll propose a patch as soon as I'm able.

Thanks! Gio'

-- 
Giovanni Biscuolo

Xelera IT Infrastructures

signature.asc
Description: PGP signature

--- End Message ---

--- Begin Message --- Subject: Re: bug#43090: [PATCH] emacs-clojure-mode 5.12.0 build failure Date: Sat, 29 Aug 2020 23:07:37 +0300 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Giovanni Biscuolo <g@xelera.eu> writes:

[…]

>> If you don't have an account, I could send it if you don't mind.
>
> Please feel free to send a pull request upstream, thank you! :-)

I've opened the pull request and pushed the fix as
0c9ead50289be04e2186666b808d0431d9326a64 to Guix master.

Oleg.

signature.asc
Description: PGP signature

--- End Message ---