bug#42906: closed ([feature/native-comp] out-of-tree build process broken)

[GNU bug Tracking System]

Your message dated Tue, 18 Aug 2020 07:24:12 +0000
with message-id <xjfpn7o8lib.fsf@sdf.org>
and subject line Re: bug#42906: [feature/native-comp] out-of-tree build process 
broken
has caused the debbugs.gnu.org bug report #42906,
regarding [feature/native-comp] out-of-tree build process broken
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
42906: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=42906
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [feature/native-comp] out-of-tree build process broken
>
>
>
>
> Date: 
>
> Mon, 17 Aug 2020 08:16:26 -0700
>
>
>
>
> When feature/native-comp branch is built out-of-tree, emacs cannot find the 
> .eln files during start.
>
> The patch below fixes this issue. The problem is caused by the fact that during 
> an out-of-tree build, default-directory points inside the build tree while the 
> .eln files are found in the source tree and because of that the subsequent 
> replace-regexp-in-string fails to adjust the file path of the compilation unit.
>
>
> modified   lisp/loadup.el
> @@ -454,7 +454,7 @@
>    ;; when installed or if the source directory got moved.  This is set to be
>    ;; a pair in the form: (rel-path-from-install-bin . rel-path-from-local-bin).
>    (let ((h (make-hash-table :test #'eq))
> -        (lisp-src-dir (expand-file-name (concat default-directory "../lisp")))
> +        (lisp-src-dir (expand-file-name "lisp" source-directory))
>          (bin-dest-dir (cadr (member "--bin-dest" command-line-args)))
>          (lisp-dest-dir (cadr (member "--lisp-dest" command-line-args))))
>      (mapatoms (lambda (s)
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#42906: [feature/native-comp] out-of-tree build process broken
>
>
>
>
> Date: 
>
> Tue, 18 Aug 2020 07:24:12 +0000
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
>
>
>
>
> Ovidiu Toader <ovi@phas.ubc.ca> writes:
>
> > On 2020-08-17 11:49 a.m., Andrea Corallo wrote:
> >> It would be great if you cold try it out and give a feedback if it works
> >> for you.
> >
> > I confirm that the new version works well with an out-of-tree build.
>
> Great, closing it.
>
> Thanks!
>
>   Andrea
>
> -- 
> akrl@sdf.org
>
>
> --- End Message ---